Skip to content

feat(storage): migrate quickstart sample and tests#4264

Open
angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:quickstart-storage-migration
Open

feat(storage): migrate quickstart sample and tests#4264
angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:quickstart-storage-migration

Conversation

@angelcaamal
Copy link
Contributor

@angelcaamal angelcaamal commented Mar 23, 2026

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added the samples Issues that are directly related to samples. label Mar 23, 2026
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 23, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new quickstart sample for the Google Cloud Storage Node.js client library, along with its associated system tests and supporting infrastructure. The primary goal is to provide a clear, executable example for users to quickly understand and implement basic Google Cloud Storage operations, specifically bucket creation, while ensuring testability and proper resource cleanup.

Highlights

  • New storage directory: A dedicated directory for Google Cloud Storage samples has been introduced, containing its own package.json and related files.
  • Quickstart sample for Cloud Storage: A quickstart.js file was added, demonstrating how to create a Google Cloud Storage bucket using the Node.js client library.
  • System tests for quickstart: Corresponding system tests (quickstart.test.js) were implemented to verify the functionality of the quickstart sample.
  • Cleanup script: A cleanup script was added to programmatically remove test resources, specifically buckets created during testing, ensuring a clean environment.
  • Sample resources: Various text files and a .gitignore were added under storage/resources to support the samples and their testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the storage quickstart sample and its tests. The changes look good overall, but I have a few suggestions to improve the code's clarity, efficiency, and robustness.

In quickstart.js, I've suggested refactoring the main function to use async/await directly, which simplifies the code.
For the cleanup script, I found the bucket deletion logic to be complex and inefficient. I've proposed a much simpler and more performant implementation using Promise.all and bucket.delete({ force: true }).
Finally, in the test file, I've recommended a small change to make the cleanup hook more robust.

Please take a look at my detailed comments.

@angelcaamal angelcaamal marked this pull request as ready for review March 23, 2026 16:34
@angelcaamal angelcaamal requested review from a team as code owners March 23, 2026 16:34
@snippet-bot
Copy link

snippet-bot bot commented Mar 23, 2026

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant