Skip to content

docs: add workflow overviews for off-cycle, dismissal, and transition payrolls#1338

Merged
jeffredodd merged 5 commits intomainfrom
docs/off-cycle-payroll-workflow
Mar 30, 2026
Merged

docs: add workflow overviews for off-cycle, dismissal, and transition payrolls#1338
jeffredodd merged 5 commits intomainfrom
docs/off-cycle-payroll-workflow

Conversation

@jeffredodd
Copy link
Copy Markdown
Contributor

Summary

  • Adds new workflow documentation for off-cycle payroll (bonus & correction), dismissal payroll, and transition payroll
  • Updates workflows overview with correct import paths, adds Information Requests to workflow list
  • All facts verified against codebase through a 10-pass automated fact-checking pipeline

New docs

  • docs/workflows-overview/off-cycle-payroll.md -- OffCycleFlow, subcomponents, props, events, form fields
  • docs/workflows-overview/dismissal-payroll.md -- DismissalFlow, integration with termination, pay period selection
  • docs/workflows-overview/transition-payroll.md -- TransitionFlow, TransitionCreation, alert behavior, skip flow

Fact-check corrections applied

  • Fixed EmployeeOnboardingFlow import to use Employee.OnboardingFlow namespace pattern
  • Added missing payrollType prop to OffCycleFlow documentation
  • Clarified TransitionPayrollAlert is internal to PayrollLanding, not a public export
  • Scoped OFF_CYCLE_SELECT_REASON/OFF_CYCLE_DEDUCTIONS_CHANGE events to standalone subcomponents only
  • Fixed dismissal integration example to pass payrollId from event data
  • Corrected event data types (payScheduleUuid can be undefined)
  • Softened transition blocking claim to reflect SDK vs API enforcement boundary
  • Matched UI label references to actual i18n strings

Test plan

  • Review each doc for accuracy against component source code
  • Verify all cross-reference links resolve correctly
  • Confirm code examples compile conceptually with current SDK API
  • Check frontmatter ordering doesn't conflict with existing docs

Made with Cursor

@jeffredodd jeffredodd force-pushed the docs/off-cycle-payroll-workflow branch from 6ec53e3 to 0f61ef7 Compare March 25, 2026 17:52
@jeffredodd jeffredodd marked this pull request as ready for review March 30, 2026 04:02
Copilot AI review requested due to automatic review settings March 30, 2026 04:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds workflow overview documentation for additional payroll workflows (off-cycle, dismissal, transition) and updates the docs entry points so integrators can discover and implement these flows using the current SDK namespace patterns.

Changes:

  • Added new workflow overview docs for Payroll.OffCycleFlow, Payroll.DismissalFlow, and Payroll.TransitionFlow (including key props/events and integration notes).
  • Updated the workflows overview page to list the new workflows and to use the Employee.* namespace pattern in the onboarding example.
  • Updated README.md to link to the new workflow docs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
docs/workflows-overview/workflows-overview.md Adds the new workflows to the overview list and updates the onboarding example import/usage to the current namespace pattern.
docs/workflows-overview/off-cycle-payroll.md New workflow doc describing off-cycle payroll flow + subcomponents, props, and events.
docs/workflows-overview/dismissal-payroll.md New workflow doc describing dismissal payroll flow, termination integration, props, and events.
docs/workflows-overview/transition-payroll.md New workflow doc describing transition payroll flow, alert behavior/events, and usage patterns.
README.md Adds links to the new workflow documentation pages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/workflows-overview/off-cycle-payroll.md
Comment thread docs/workflows-overview/dismissal-payroll.md
Comment thread docs/workflows-overview/transition-payroll.md
Comment thread docs/workflows-overview/transition-payroll.md
jeffredodd added a commit that referenced this pull request Mar 30, 2026
Addresses Copilot review feedback on PR #1338: the integration example
guards on data.payScheduleUuid because TransitionFlow requires it as a
non-optional prop, but the event type allows undefined. Added a note
explaining this and suggesting partners add fallback logic if needed.

Made-with: Cursor
@jeffredodd jeffredodd enabled auto-merge (squash) March 30, 2026 16:43
Ran 10-pass automated fact-checking pipeline against the codebase to
verify all claims in the off-cycle, dismissal, transition, and
workflows-overview docs. Key corrections:

- Fix EmployeeOnboardingFlow import to use Employee.OnboardingFlow namespace
- Add missing payrollType prop to OffCycleFlow docs
- Clarify TransitionPayrollAlert is internal to PayrollLanding, not a public export
- Scope OFF_CYCLE_SELECT_REASON/DEDUCTIONS_CHANGE events to standalone subcomponents
- Fix dismissal integration example to pass payrollId from event data
- Correct event data types (payScheduleUuid can be undefined)
- Soften transition blocking claim to reflect SDK vs API enforcement
- Match UI label references to actual i18n strings
- Add Information Requests to workflows list
- Normalize code style (semicolons, formatting)

Made-with: Cursor
Verified all three payroll workflow docs (off-cycle, dismissal,
transition) through 10 systematic passes against source code.

- Reorder off-cycle form fields and workflow steps to match UI render
  order (dates first, then reason)
- Use API wire value "Dismissed employee" instead of TypeScript enum
  name in dismissal doc prose
- Clarify transition pay schedule field is conditionally shown
- Specify transition tax withholding default frequency (every-other-week)

Made-with: Cursor
Addresses Copilot review feedback on PR #1338: the integration example
guards on data.payScheduleUuid because TransitionFlow requires it as a
non-optional prop, but the event type allows undefined. Added a note
explaining this and suggesting partners add fallback logic if needed.

Made-with: Cursor
@jeffredodd jeffredodd force-pushed the docs/off-cycle-payroll-workflow branch from 23fbb6d to 476d8f9 Compare March 30, 2026 16:44
@jeffredodd jeffredodd merged commit 43081c3 into main Mar 30, 2026
15 checks passed
@jeffredodd jeffredodd deleted the docs/off-cycle-payroll-workflow branch March 30, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants