[Enhancement] 账户列表优化#6093
Conversation
Co-authored-by: A01-opika <opika2022@outlook.com>
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces search functionality and drag-and-drop reordering for the account list page. The review feedback highlights several critical improvements: wrapping the reordering list operations in a try-finally block to guarantee that the selection check flag is safely reset, preventing a potential NullPointerException by checking for null search queries before converting to lowercase, and avoiding an IndexOutOfBoundsException by validating the index when toggling an account's portable status.
Glavo
left a comment
Glavo
left a comment
There was a problem hiding this comment.
本 PR 可以把全局账户拖到便携账户中间，但实际这两类账户被存储在不同的文件里，这种次序不会被持久化，下次启动 HMCL 后次序会丢失。
Solved |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements account searching and drag-and-drop reordering in the account list page. The review feedback highlights several critical and high-severity issues, including a potential IndexOutOfBoundsException when loading accounts with out-of-bounds indices, loss of selection state when moving accounts, potential NullPointerExceptions during search filtering, list corruption if drag-and-drop is performed while searching, and potential layout calculation inaccuracies during drag-and-drop target indexing.
2 participants
Closes #5999 Resolves #5615 Resolves #3046