fix(#6154): layout race in instance download page#6155
Open
SALTWOOD wants to merge 4 commits into
Open
Conversation
Member
|
/gemini review |
SALTWOOD
changed the title
NaN with a placeholder value![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the layout of TwoLineListItem by removing the ScrollPane wrapper around tagsBox and placing tagsBox directly into firstLine. It also binds the managed and visible properties of tagsBox to the presence of tags. A review comment suggests extracting the duplicate Bindings.isNotEmpty(tags) call into a local variable to avoid creating multiple binding instances and duplicate listeners, which helps reduce memory overhead and GC pressure.
…Item.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Member
tag 多的时候又会全部被挤压成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6154
这边怀疑是 race condition 导致没能成功设置标签的
Height属性，所以选择了一个不大不小的值放在上面，暂时解决了问题。如果可能的话，我会尝试寻找更好的方法修好需要更多测试。该修改之后，我已无法再复现此问题，但是不排除测试姿势不对导致的复现失败。