Skip to content

修复无法为 MC 1.21.11 安装 Forge 的问题#6160

Merged
Glavo merged 2 commits into
HMCL-dev:mainfrom
Glavo:parse-instant
Jun 2, 2026
Merged

修复无法为 MC 1.21.11 安装 Forge 的问题#6160
Glavo merged 2 commits into
HMCL-dev:mainfrom
Glavo:parse-instant

Conversation

@Glavo
Copy link
Copy Markdown
Member

@Glavo Glavo commented Jun 2, 2026

No description provided.

@Glavo
Copy link
Copy Markdown
Member Author

Glavo commented Jun 2, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation comments, restructures the deserialize method, and attempts to support single-digit hour offsets in the ISO_DATE_TIME formatter. However, a critical issue was identified: DateTimeFormatterBuilder.appendOffset does not support the +H:MM pattern, which will cause an IllegalArgumentException and crash the application during class loading. A regex-based preprocessing approach is suggested to safely handle single-digit offsets.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Glavo Glavo merged commit 40d21bb into HMCL-dev:main Jun 2, 2026
2 checks passed
@Glavo Glavo deleted the parse-instant branch June 2, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant