Skip to content

Consolidate slot config into trusted-server.toml and namespace window globals under window._ts #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
prk-Jr wants to merge 14 commits into
base: server-side-ad-templates-impl
Choose a base branch
from
Draft

Consolidate slot config into trusted-server.toml and namespace window globals under window._ts #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
428d4ed
Move slot templates from creative-opportunities.toml into trusted-ser…
prk-Jr May 29, 2026
9fe0f34
Namespace window globals under window._ts
prk-Jr May 29, 2026
cac4fd0
Fix ts.bids comment and test teardown in GPT globals rename
prk-Jr May 29, 2026
9aa7e89
Fix TsAdSlot formats type and extract ts_initial constant
prk-Jr May 29, 2026
2fa3eb8
Fix prettier formatting in reviewer findings plan doc
prk-Jr May 29, 2026
e592c3b
Add spec: Prebid creative rendering fix (hb_adid cache UUID + cache h…
prk-Jr May 29, 2026
be0ca38
Update spec: add AuctionBid conversion note, partial cache warning, T…
prk-Jr May 29, 2026
793a523
Add implementation plan: Prebid creative rendering fix
prk-Jr May 29, 2026
24f1c26
Add cache_id, cache_host, cache_path fields to Bid struct
prk-Jr May 29, 2026
7c31415
Fix rustfmt in parse_bid cache extraction tests
prk-Jr May 29, 2026
fc8b94d
Emit hb_adid from PBS Cache UUID and add hb_cache_host/hb_cache_path …
prk-Jr May 29, 2026
c44ae51
Integrate window._ts to window.tsjs
prk-Jr Jun 1, 2026
af6341d
Forward hb_cache_host/hb_cache_path to GPT targeting and add test cov…
prk-Jr Jun 1, 2026
d511897
Add inject_adm_for_testing debug flag for end-to-end creative validation
prk-Jr Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions crates/js/lib/src/core/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,28 @@ export interface AdUnit {
bids?: Bid[];
}

/** Minimal shape of a server-side auction slot injected into `window.tsjs.adSlots`. */
export interface AuctionSlot {
id: string;
gam_unit_path: string;
div_id: string;
formats: Array<[number, number]>;
targeting?: Record<string, string>;
}

/** Bid targeting data from the server-side auction, injected into `window.tsjs.bids`. */
export interface AuctionBidData {
hb_pb?: string;
hb_bidder?: string;
hb_adid?: string;
hb_cache_host?: string;
hb_cache_path?: string;
nurl?: string;
burl?: string;
/** Raw creative markup. Only present when `[debug] inject_adm_for_testing = true`. */
adm?: string;
}

export interface TsjsApi {
version: string;
que: Array<() => void>;
Expand All @@ -41,4 +63,20 @@ export interface TsjsApi {
error(...args: unknown[]): void;
debug(...args: unknown[]): void;
};

// ── Server-side auction runtime (populated by TS edge injection) ──────────
/** Ad slot definitions injected at <head> open. */
adSlots?: AuctionSlot[];
/** Winning bid targeting data injected before </body>. */
bids?: Record<string, AuctionBidData>;
/** Initialises GPT slots with server-side bid targeting and calls refresh(). */
adInit?: () => void;
/** GPT slot objects TS defined — used to destroy stale slots on SPA navigation. */
prevGptSlots?: unknown[];
/** Guards one-time-per-page enableSingleRequest/enableServices calls. */
servicesEnabled?: boolean;
/** Maps actualDivId → slotId for slotRenderEnded billing lookup. */
divToSlotId?: Record<string, string>;
/** Guards SPA pushState hook installation. */
spaHookInstalled?: boolean;
}
Loading
Loading