Experimental: ignore non-explicit groups (IP groups, specifically) when making solr queries #12149
Draft
Experimental: ignore non-explicit groups (IP groups, specifically) when making solr queries #12149
Conversation
|
coverage: 24.886% (-0.001%) from 24.887% — prodpatch-solr-skip-ip-groups into develop |
This comment has been minimized.
This comment has been minimized.
FeatureFlags (for "skip non-explicit groups") A local mod that skips non-explicit groups when the corresponding flag is defined.
landreev
force-pushed
the
prodpatch-solr-skip-ip-groups
branch
from
cc9e23f to
22b2b76
Compare
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This was a quick prod. experiment: We have IP groups defined that make a fairly large numbers of otherwise guest/unprivileged users members of at least one group. As of right now however there doesn't seem to be any cases where this group membership results in any extra rights as far as indexing and searching is concerned. So, dropping these allows to build simplified Solr queries without a single JOIN (in combo with the "avoid expensive join" flag).
I do not have any quantitative data showing that this resulted in any real savings. Just an experiment/was something that was rubbing me the wrong way.
No intent to merge this into main develop.
Making a draft PR to have these commits in one place for convenient cherry-picking into future prod. patches.
I will delete it if/when I think of a cleaner way to maintain these custom mods. (A prodpatch fork is probably the way to go).
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: