Conversation
We are beginning to hit concurrency limits of GH actions if there are many pushes in a row since we do run quite a lot of jobs. This should automatically cancel the old jobs for a particular PR if there is a more recent push. All credit goes to @DilumAluthge.
|
I think this is not yet correct. We need to give every job its own group, otherwise only one job will run and cancel all the rest. |
|
Hmmm. This should be handled by |
|
Oh I see what you mean. You mean different workflow files. I'll make a PR. Basically we should put the name of the workflow file into the group. |
|
Yes, that's what I did in #466 |
Ah you beat me to it 😂 |
* follow up to #464 ref #464 (comment) * implement @DilumAluthge's suggestion
|
Not sure if it's helpful, but in the JuliaGPs ecosystem we make extensive use of this action to cancel existing jobs. Credit goes to @devmotion IIRC. |
|
I was wondering if we could update it to the approach in this PR? It seems it should work in the same way? Seems nice to use an official functionality instead of a custom action. |
|
Yeah, I would recommend switching to the official functionality. |
|
Already opened a PR: JuliaGaussianProcesses/KernelFunctions.jl#368 🙂 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #464 +/- ##
==========================================
- Coverage 92.98% 92.49% -0.49%
==========================================
Files 14 13 -1
Lines 812 799 -13
==========================================
- Hits 755 739 -16
- Misses 57 60 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 participants
We are beginning to hit concurrency limits of GH actions if there are
many pushes in a row since we do run quite a lot of jobs. This should
automatically cancel the old jobs for a particular PR if there is a more
recent push.
All credit goes to @DilumAluthge.