Skip to content

follow up to #464#466

Merged
simeonschaub merged 2 commits intomasterfrom
sds/cancel_intermediate
Sep 21, 2021
Merged

follow up to #464#466
simeonschaub merged 2 commits intomasterfrom
sds/cancel_intermediate

Conversation

@simeonschaub
Copy link
Copy Markdown
Member

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 21, 2021

Codecov Report

Merging #466 (4ed6ccf) into master (1893e82) will decrease coverage by 0.01%.
The diff coverage is 97.67%.

❗ Current head 4ed6ccf differs from pull request most recent head f6703bc. Consider uploading reports for the commit f6703bc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
- Coverage   92.96%   92.94%   -0.02%     
==========================================
  Files          14       13       -1     
  Lines         810      808       -2     
==========================================
- Hits          753      751       -2     
  Misses         57       57              
Impacted Files Coverage Δ
src/tangent_types/abstract_tangent.jl 50.00% <ø> (ø)
src/tangent_types/abstract_zero.jl 85.00% <ø> (ø)
src/tangent_types/notimplemented.jl 70.83% <ø> (ø)
src/tangent_types/thunks.jl 95.00% <ø> (ø)
src/tangent_types/tangent.jl 84.37% <97.43%> (ø)
src/projection.jl 98.11% <100.00%> (+<0.01%) ⬆️
src/tangent_arithmetic.jl 96.33% <100.00%> (ø)
src/rule_definition_tools.jl 96.12% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19700de...f6703bc. Read the comment docs.

@DilumAluthge
Copy link
Copy Markdown
Member

DilumAluthge commented Sep 21, 2021

If you want to simplify things further, you can do the same line in all of the workflow files as follows:

group: ${{ github.workflow }}-${{ github.ref }}

Then, if e.g. you rename the workflow file in the future, you don't need to manually update the group.

See the section on the github context here: https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#github-context

Comment thread .github/workflows/CI.yml Outdated
Comment thread .github/workflows/IntegrationTest.yml Outdated
Comment thread .github/workflows/JuliaNightly.yml Outdated
@simeonschaub simeonschaub force-pushed the sds/cancel_intermediate branch from 4ed6ccf to f6703bc Compare September 21, 2021 22:37
@simeonschaub
Copy link
Copy Markdown
Member Author

Perfect, seems to work now.

@simeonschaub simeonschaub merged commit 3ccd3c1 into master Sep 21, 2021
@simeonschaub simeonschaub deleted the sds/cancel_intermediate branch September 21, 2021 22:38
@mzgubic
Copy link
Copy Markdown
Member

mzgubic commented Sep 22, 2021

Oh that's fantastic, thank you! I tried doing that a while ago but gave up. Any chance you would be willing to add this to ChainRules as well? Those pipelines take much longer usually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants