Skip to content

Fix #714: Make TAGCOUNT always greater than the last instantiated Tag's count#724

Open
Technici4n wants to merge 1 commit intoJuliaDiff:masterfrom
Technici4n:fix-714
Open

Fix #714: Make TAGCOUNT always greater than the last instantiated Tag's count#724
Technici4n wants to merge 1 commit intoJuliaDiff:masterfrom
Technici4n:fix-714

Conversation

@Technici4n
Copy link
Copy Markdown

This fixes #714:

     Testing Running tests...
Tag count of Dual{ForwardDiff.Tag{FDPrecompilationIssue.var"#3#4"{Int64}, Int64}}(0,1) is 1
Tag count of Dual{ForwardDiff.Tag{FDPrecompilationIssue.var"#1#2"{ForwardDiff.Dual{ForwardDiff.Tag{FDPrecompilationIssue.var"#3#4"{Int64}, Int64}, Int64, 1}}, ForwardDiff.Dual{ForwardDiff.Tag{FDPrecompilationIssue.var"#3#4"{Int64}, Int64}, Int64, 1}}}(Dual{ForwardDiff.Tag{FDPrecompilationIssue.var"#3#4"{Int64}, Int64}}(0,0),Dual{ForwardDiff.Tag{FDPrecompilationIssue.var"#3#4"{Int64}, Int64}}(0,2)) is 2
     Testing FDPrecompilationIssue tests passed

This adds an atomic operation for each Tag instantiation. This might be problematic when computing many fast derivatives in a tight loop?

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 18, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.76%. Comparing base (c310fb5) to head (4cb3336).
⚠️ Report is 53 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   89.57%   86.76%   -2.81%     
==========================================
  Files          11       10       -1     
  Lines         969      922      -47     
==========================================
- Hits          868      800      -68     
- Misses        101      122      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Precompilation can lead to Dual tag ordering problems

1 participant