Conversation
dolaameng
left a comment
dolaameng
left a comment
There was a problem hiding this comment.
LGTM. Thank you @nl917 !
Would like @stevemessick to take a look.
| @@ -1,4 +1,4 @@ | |||
| __version__ = "0.1.16" | |||
| __version__ = "0.1.17" | |||
There was a problem hiding this comment.
I don't know the release process of kaggle-sdk but I suppose there is some manual step here to actually publish this package. I don't know how kaggle-cli imports this package. It used be a manual copy but I am not sure if that has changed. @stevemessick knows better
There was a problem hiding this comment.
Just realized Steve is OOO this week. Requested review from Jonathan instead
There was a problem hiding this comment.
Yes @nl917 I think these are experimental features only with placeholder code but not real implementation? Checking in the code is to help unblock downstream application. But if this got published to pypi, we probably just wait till everything is implemented by @andrewmwang first.
There was a problem hiding this comment.
I'm also not super familiar with recent implementations/updates to the sdk but I can do a quick look over and see if anything stands out
| The slug for the task without the user's namespace. (ex: my-task instead of | ||
| username/my-task). This should match the slug in the kaggle-benchmarks | ||
| decorator in the code. | ||
| text (str) |
There was a problem hiding this comment.
@andrewmwang Can you confirm this the text for the .py source code? And on the server side, a .py file with delimiters like # %% will be converted to a ipython notebook properly?
| r""" | ||
| Attributes: | ||
| task_slugs (ApiBenchmarkTaskSlug) | ||
| model_slugs (str) |
There was a problem hiding this comment.
@nl917 @andrewmwang what's the behavior here when model_slugs is empty list []. Will it run on all models, or no models?
4 participants
Uh oh!
There was an error while loading. Please reload this page.