Open
Conversation
…on v2 integration-manifest Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
…for creating test certs, etc. Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, trying to lookup shopper IDs in the GoDaddy OTE environment always results in an HTTP 404 issue. Not sure if this is a recent issue. While the docs do point out to use production API credentials, calling out the OTE environment led to confusion.
I suggest we remove calling out OTE at all in this documentation and very clearly lay out why production must be used to test.
Some additional changes were to rename the unit tests and also reduce the computational overhead going on in the tests -- it was generating certificates for every unit test where it only needed to generate a single certificate. This cut down the test runtime by over 50%.