Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
objects/contact-list/definition.jsonthat models contact fields (full-name,first-name,last-name,phone-number,e-mail,organisation,handle,address,note,raw-base64) and extraction context (extraction-tool,extraction-type,source-device,source-platform,extracted-at,extraction-reference,contact-count).requiredOneOf(full-name,phone-number,e-mail,contact-id) to keep ingestion flexible for partial exports and setversionto1with a generateduuid.sane_defaultvalues forextraction-toolincludingCellebrite UFED,Cellebrite Physical Analyzer,MSAB XRY,Magnet AXIOM,Oxygen Forensic Detective,Belkasoft X, andElcomsoft iOS Forensic Toolkitto explicitly cover Cellebrite and similar workflows.README.mdso it appears in the documented object catalog.Testing
./jq_all_the_things.sh, which completed formatting but logged missing environment helper (uuidparse) warnings; the script processed files.python unique_uuid.pyand it reported no duplicate UUIDs in the tree (success)../validate_all.sh, which failed in this environment due to missing tooling (uuidparse,jsonschema) and the repository cleanliness guard, so full schema validation could not be completed here (failure).jsonschema -i objects/contact-list/definition.json schema_objects.jsonbut thejsonschemabinary was not available in the environment (not run).Codex Task