config endpoint must handle functions in module configs#4106
Merged
sdetweil merged 2 commits intoMagicMirrorOrg:developfrom Apr 12, 2026
Merged
config endpoint must handle functions in module configs#4106sdetweil merged 2 commits intoMagicMirrorOrg:developfrom
sdetweil merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
Collaborator
|
Smart solution! I noticed some small polish points around the function-tagging flow on the server/client side (plus one small edge-case test for plain strings). Would you be okay with me adding a follow-up commit to your branch? Would be easier than commenting. |
Collaborator
Author
|
Sure |
Replace heuristic string detection for function revival with an explicit __mmFunction tag to avoid false positives for plain text containing "function" or "=>". Add comments clarifying the server/client serialization contract and extend e2e coverage to ensure normal strings are not revived.
Collaborator
|
Just pushed a commit: functions are now explicitly marked during serialization instead of guessed, which should make the flow safer and prevents false positives on plain strings. What do you think? |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4105