TICKET-614: Add case sensitivy to group search by Naragod · Pull Request #7938 · MarkUsProject/Markus

Naragod · 2026-05-08T21:05:11Z

Proposed Changes

Add case sensitivity to group search.

Screenshots of your changes (if applicable)

Screen.Recording.2026-05-08.at.5.04.27.PM.mov

Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)	X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

I have performed a self-review of my changes.
- Check that all changed files included in this pull request are intentional changes.
- Check that all changes are relevant to the purpose of this pull request, as described above.
I have added tests for my changes, if applicable.
- This is required for all bug fixes and new features.
I have updated the project documentation, if applicable.
- This is required for new features.
If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

I have updated the project Changelog (this is required for all changes).
I have verified that the pre-commit.ci checks have passed.
I have verified that the CI tests have passed.
I have reviewed the test coverage changes reported by Coveralls.
I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

coveralls · 2026-05-08T21:31:21Z

Coverage Report for CI Build 26381691124

Coverage increased (+0.03%) to 90.285%

Details

Coverage increased (+0.03%) from the base build.
Patch coverage: 20 uncovered changes across 3 files (55 of 75 lines covered, 73.33%).
No coverage regressions found.

Uncovered Changes

File	Changed	Covered	%
app/javascript/Components/groups_manager.jsx	38	22	57.89%
app/javascript/Components/annotation_usage_panel.jsx	15	12	80.0%
app/javascript/Components/graders_manager.jsx	3	2	66.67%

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	49844
Covered Lines:	45971
Line Coverage:	92.23%
Relevant Branches:	2177
Covered Branches:	996
Branch Coverage:	45.75%
Branches in Coverage %:	Yes
Coverage Strength:	122.82 hits per line

💛 - Coveralls

donny-wong

Thank you @Naragod , looks good. Please update branch and I will approve it at that time. Thank you.

david-yz-liu

@Naragod Nice work! Sorry I took a while to review this. The UI is very nice and I appreciate the attention to consistency across components.

I left two comments, one of which is describes a change to the approach that causes a bit of work but I think will result in a nice simplification of these changes. Please feel free to message on Slack if you'd like to chat further about this.

donny-wong

Looks good @Naragod. Please resolve branch conflicts. Thanks.

david-yz-liu

@Naragod nice work, the change ended up being even simpler than I thought! I left a few more comments about functionality and some code cleanup. As Donny noted, please do also update with master and resolve the conflict.

david-yz-liu · 2026-05-28T15:28:24Z

    this.state = {
      applications: null,
      details: false,
+      columns: this.getColumns(),


Because you've changed the approach to have the filter state not be stored here, most of the changes in this file should be reverted to what we currently have in master. The only thing that needs to change is in the column definition for group_name is to update the filter and filterMethod values. No other changes are necessary; please revert them.

david-yz-liu · 2026-05-28T15:29:34Z

    super(props);
    this.state = {
      filtered: [],
-      columns: this.getColumns(props.showSections, props.sections, props.showCoverage),


These changes are not necessary. Please keep the changes to just the filter and filterMethod properties for the column with the new case-(in)sensitive filter.

david-yz-liu · 2026-05-28T15:30:17Z

+        Header: I18n.t("activerecord.models.group.one"),
+        accessor: "group_name",
+        id: "group_name",
+        Filter: caseSensitiveTextFilter,


Same comment as above

david-yz-liu · 2026-05-28T15:31:36Z

    this.createChannelSubscriptions();
  }

+  groupNameFilter = (filter, row) => {


Keep the original method. The only thing that needs to change is adding const {filterValue, caseSensitive} = filter.value; and then replacing the uses of filter.value throughout. The structure should remain the same; don't rewrite it.

david-yz-liu · 2026-05-28T15:33:29Z

+ * against them.
+ */
+export function caseSensitiveIncludes(haystack, needle, caseSensitive) {
+  const a = haystack == null ? "" : String(haystack);


I don't like using == as it introduces type coercion. Please use the more explicit haystack === null || haystack === undefined instead.

david-yz-liu · 2026-05-28T15:37:38Z

+ */
+export function caseSensitiveTextFilter({filter, onChange, column}) {
+  const filterValue = filter ? filter.value.filterValue : "";
+  const caseSensitive = filter ? filter.value.caseSensitive : true;


let's make the default false (this is the most typical usecase)

Naragod added this to the v2.9.7 milestone May 8, 2026

Naragod requested a review from donny-wong May 8, 2026 21:05

Naragod linked an issue May 8, 2026 that may be closed by this pull request

Bug: Case-insensitive group filtering for 'A' in Graders tab #7927

Open

donny-wong reviewed May 12, 2026

View reviewed changes

Naragod force-pushed the TICKET-614_add_case_sensitivity_to_group_search branch from 00a015a to 9765181 Compare May 12, 2026 23:27

Naragod requested a review from donny-wong May 12, 2026 23:27

donny-wong approved these changes May 13, 2026

View reviewed changes

donny-wong requested a review from david-yz-liu May 13, 2026 02:02

david-yz-liu reviewed May 21, 2026

View reviewed changes

Comment thread app/javascript/Components/Helpers/table_helpers.jsx Outdated

Comment thread app/javascript/Components/Helpers/table_helpers.jsx Outdated

Naragod added 3 commits May 24, 2026 23:30

TICKET-614: Add case sensitivy to group search

ff6c97a

TICKET-614: Update Changelog

c0d6a1f

TICKET-614: Move case-sensitive toggle into filter value

34449a4

Naragod force-pushed the TICKET-614_add_case_sensitivity_to_group_search branch from e4623a5 to 34449a4 Compare May 25, 2026 03:31

Naragod requested review from david-yz-liu and donny-wong May 25, 2026 03:35

donny-wong approved these changes May 26, 2026

View reviewed changes

david-yz-liu reviewed May 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TICKET-614: Add case sensitivy to group search#7938

TICKET-614: Add case sensitivy to group search#7938
Naragod wants to merge 3 commits into
masterfrom
TICKET-614_add_case_sensitivity_to_group_search

Naragod commented May 8, 2026 •

edited

Loading

Uh oh!

coveralls commented May 8, 2026 •

edited

Loading

Uh oh!

donny-wong left a comment

Uh oh!

david-yz-liu left a comment

Uh oh!

Uh oh!

Uh oh!

donny-wong left a comment

Uh oh!

david-yz-liu left a comment

Uh oh!

david-yz-liu May 28, 2026

Uh oh!

david-yz-liu May 28, 2026

Uh oh!

david-yz-liu May 28, 2026

Uh oh!

david-yz-liu May 28, 2026

Uh oh!

david-yz-liu May 28, 2026

Uh oh!

david-yz-liu May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Naragod commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Type of Change

Checklist

Questions and Comments

Uh oh!

coveralls commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 26381691124

Coverage increased (+0.03%) to 90.285%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

donny-wong left a comment

Choose a reason for hiding this comment

Uh oh!

david-yz-liu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

donny-wong left a comment

Choose a reason for hiding this comment

Uh oh!

david-yz-liu left a comment

Choose a reason for hiding this comment

Uh oh!

david-yz-liu May 28, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu May 28, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu May 28, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu May 28, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu May 28, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Naragod commented May 8, 2026 •

edited

Loading

coveralls commented May 8, 2026 •

edited

Loading