Skip to content

Fix invalid json error handling#622

Merged
MarcelGeo merged 1 commit into
developfrom
fix_error_handling
May 11, 2026
Merged

Fix invalid json error handling#622
MarcelGeo merged 1 commit into
developfrom
fix_error_handling

Conversation

@varmar05
Copy link
Copy Markdown
Collaborator

@varmar05 varmar05 commented May 8, 2026

Fix the parsing error issue if response was not json type (eg. proxied request) or invalid json body.

@varmar05 varmar05 requested a review from MarcelGeo May 8, 2026 09:18
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25547627286

Coverage decreased (-0.07%) to 93.142%

Details

  • Coverage decreased (-0.07%) from the base build.
  • Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).
  • 28 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

28 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
server/mergin/sync/storages/disk.py 26 82.47%
server/mergin/tests/test_disk_utils.py 2 96.23%

Coverage Stats

Coverage Status
Relevant Lines: 9813
Covered Lines: 9140
Line Coverage: 93.14%
Coverage Strength: 0.93 hits per line

💛 - Coveralls

@MarcelGeo MarcelGeo merged commit 1b65c10 into develop May 11, 2026
4 checks passed
@MarcelGeo MarcelGeo deleted the fix_error_handling branch May 11, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants