feat(gpu): move device selection to driver config#1815
Conversation
14e335a to
5b6ab51
Compare
|
🌿 Preview your docs: https://nvidia-preview-pr-1815.docs.buildwithfern.com/openshell |
5b6ab51 to
67bc3f6
Compare
e988248 to
7c7fc4d
Compare
7c7fc4d to
63e4671
Compare
63e4671 to
6817cbc
Compare
6817cbc to
0df61f4
Compare
|
Label |
0df61f4 to
253644c
Compare
PR Review StatusValidation: this is maintainer-authored, project-valid GPU driver/API boundary work related to #1716 and #1812. Review findings:
Docs: Fern docs were updated for the new Next state: |
Re-check After Author UpdateI re-evaluated latest head Disposition: partially resolved. Remaining items:
Next state: |
Re-check After Author UpdateI re-evaluated latest head Disposition: resolved. Remaining items:
Checks: required checks need to run again for the new head; Next state: |
Maintainer Approval NeededGator validation and PR monitoring are complete. Validation: maintainer-authored GPU driver/API boundary work scoped to moving device selection into driver configuration. Human maintainer approval or merge decision is now required. |
BlockedGator is blocked by merge conflicts: GitHub now reports Next action: @elezar update the branch against current Next state: |
b68e440 to
7021d16
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
BREAKING CHANGE: The openshell sandbox create --gpu-device flag and corresponding API field were removed. Select specific GPUs through driver-specific driver_config fields instead. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
7021d16 to
70acb90
Compare
Re-check After Author UpdateI re-evaluated latest head Disposition: resolved for the blocker. GitHub no longer reports Remaining items:
Next state: |
Maintainer Approval NeededGator validation and PR monitoring are complete for the updated branch. Validation: maintainer-authored GPU driver/API boundary work scoped to moving device selection into driver configuration. Human maintainer approval or merge decision is now required. |
Re-check After Maintainer ReviewI re-evaluated latest head Disposition: approval received. Remaining items:
Next state: |
Summary
Move exact GPU device selection out of the public sandbox proto/API and into driver-specific
driver_configfields.Related Issue
Related to #1716 and #1812.
Changes
gpu_devicefields, reserving the field numbers and names.--gpu-deviceflag.driver_config.cdi_devices.driver_config.gpu_device_ids, currently limited to one entry.gpu=truewhen exact GPU device config is supplied, and reject exact selection for Kubernetes.--driver-config-jsonpath.Testing
mise run pre-commitpassesChecklist