feat(helm): support Deployment kind in HA gateway workloads#1867
Merged
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
TaylorMutch
requested review from
a team,
derekwaynecarr and
mrunalp
as code owners
|
🌿 Preview your docs: https://nvidia-preview-pr-1867.docs.buildwithfern.com/openshell |
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
krishicks
previously approved these changes
Jun 10, 2026
krishicks
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an explicit Helm workload selector so external database-backed gateway installs can run as a Deployment while preserving StatefulSet as the SQLite default.
Related Issue
Closes #1866
Changes
workload.kindwithstatefulsetanddeploymentoptions.Testing
mise run pre-commitpassesAdditional targeted checks run:
mise run helm:testmise run helm:lintmise run helm:docs:checkChecklist