Allow webhook ping events for unapproved plugins#347
Merged
Conversation
Move the X-GitHub-Event header check before the plugin approval gate so that GitHub's test ping returns 200 regardless of plugin status. This lets developers verify webhook setup before their plugin is approved. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-GitHub-Eventheader check before the plugin approval gate inPluginWebhookController200response forpingevents regardless of plugin approval statusThis fixes an issue where developers setting up webhooks manually would get a 403 on GitHub's test ping because their plugin wasn't yet approved, making it look like the webhook was misconfigured.
Test plan
🤖 Generated with Claude Code