nbd-server: drop the double-fork#184
Open
eworm-de wants to merge 1 commit intoNetworkBlockDevice:masterfrom
Open
nbd-server: drop the double-fork#184eworm-de wants to merge 1 commit intoNetworkBlockDevice:masterfrom
eworm-de wants to merge 1 commit intoNetworkBlockDevice:masterfrom
Conversation
... as this breaks as systemd service: This is of type 'forking', so the (first) fork becomes the main and controlling process. The second fork makes the main process exit, and the service is stopped. Calling setsid() should be sufficient to detatch from terminal. Closes: NetworkBlockDevice#182
|
Instead of straight removal, I'd try to find an adequate macro to put around that code: something like |
Contributor
Author
|
Do others actually need this? And how did the old code manage this? |
|
I think this is the historical way of doing "daemons" processes. Maybe what's needed for systemd is the "-n" CLI argument. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as this breaks as systemd service: This is of type 'forking', so the (first) fork becomes the main and controlling process. The second fork makes the main process exit, and the service is stopped.
Closes: #182