Skip to content

fix: add favicon.ico support #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GulshanJha00 wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −0
Open

fix: add favicon.ico support #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f3c09c
fix: add favicon.ico support
GulshanJha00 May 3, 2026
572a1cd
style: remove favicon cache-busting query
GulshanJha00 May 3, 2026
b6afc16
style: use Eleventy url filter for favicon
GulshanJha00 May 3, 2026
f31daab
Merge branch 'main' into fix-favicon-clean
jbampton May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eleventy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module.exports = (eleventyConfig) => {
eleventyConfig.addShortcode("currentYear", () => new Date().getFullYear());
// Add this line to copy your external assets
eleventyConfig.addPassthroughCopy("src/assets");
eleventyConfig.addPassthroughCopy("src/favicon.ico");
// 1. Recognize YAML as a template format
eleventyConfig.addTemplateFormats("yaml");

Expand Down
Binary file added src/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions src/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ layout: false
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Developer Directory</title>
<link rel="icon" type="image/x-icon" href="{{ '/favicon.ico' | url }}">
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The addition of the url filter for the favicon is a good practice for supporting subpath deployments (e.g., GitHub Pages). However, I noticed that the existing stylesheet links on the following lines (11 and 12) do not use this filter. This creates an inconsistency where the favicon might load correctly on a subpath while the CSS fails. For full portability, you should consider applying the url filter to all internal assets in the <head>.

<link rel="stylesheet" href="/assets/css/tailwind.css">
<link rel="stylesheet" href="/assets/css/style.css">
</head>
Expand Down
Loading