Add Entity/EntityRep ID comparison tests#949
Merged
aritorto merged 2 commits intoOPM:masterfrom Jan 26, 2026
Merged
Conversation
SoilRos
added
the
manual:irrelevant
aritorto
requested changes
Nov 19, 2025
Member
aritorto
left a comment
aritorto
left a comment
There was a problem hiding this comment.
Nice clean-up and reorganization of the checks! I left a few comments and questions below : )
SoilRos
force-pushed
the
test/id-Entity-vs-EntityRep
branch
from
715ae3f to
9f113ed
Compare
Member
Author
|
jenkins build this please |
1 similar comment
Member
Author
|
jenkins build this please |
SoilRos
force-pushed
the
test/id-Entity-vs-EntityRep
branch
from
f944ada to
0c9c5c4
Compare
This patch adds a test that compares the ids and indices for Entity and EntityRep. The idea is that we can split the two functionalities (because the are different) without breaking the current functionality.
Add descriptions that reflect and explain better what is being tested, including the reasoning behind some TODOs.
SoilRos
force-pushed
the
test/id-Entity-vs-EntityRep
branch
from
0c9c5c4 to
0a9c5b0
Compare
Member
Author
|
jenkins build this please |
Member
|
@SoilRos thanks for the update, one last jenkins call before merging |
Member
|
jenkins build this serial please |
Member
|
No test fails, that's great. However, there are 40 warnings (previous build has 21, not sure where the difference comes from). @SoilRos, do you see any way to silence/reduce (some of) them? |
Member
|
they are duplicated due to the extra configuration, there are no new warnings introduced by this PR. |
Member
|
Thanks for clarifying @akva2, then this is ready to be merged! |
aritorto
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a test that compares the ids and indices for Entity and EntityRep. The idea is that we can split the two functionalities (because the are different) without breaking the current functionality.
This is a re-work of the test introduced by @aritorto in #905 and #898, but without the modifications to the index set yet.
From what I understand, the desired behavior is that Entity and EntityRep have the same global/local id at the level zero when the grid is not distributed. Otherwise, the ids should be different. This test shows that that is the case for local ids, but fails for global ids when the grid is in parallel.
The test case is marked with
TODOs on the places that are not currently working according to my testing.