Skip to content

feat(spring): enable openApiNullable with useJackson3#23331

Open
sonallux wants to merge 2 commits intoOpenAPITools:masterfrom
sonallux:fix/23324-openApiNullable-with-useJackson3
Open

feat(spring): enable openApiNullable with useJackson3#23331
sonallux wants to merge 2 commits intoOpenAPITools:masterfrom
sonallux:fix/23324-openApiNullable-with-useJackson3

Conversation

@sonallux
Copy link
Copy Markdown
Contributor

@sonallux sonallux commented Mar 24, 2026

fixes #23324

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sonallux sonallux force-pushed the fix/23324-openApiNullable-with-useJackson3 branch from d6aa46c to c4484f0 Compare March 24, 2026 21:12
@sonallux sonallux changed the title feat: enable openApiNullable with useJackson3 feat(spring): enable openApiNullable with useJackson3 Mar 24, 2026
@sonallux sonallux marked this pull request as ready for review March 24, 2026 21:35
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 296 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 25, 2026

thanks for the PR

please review the build failure when you've time

cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

@sonallux sonallux force-pushed the fix/23324-openApiNullable-with-useJackson3 branch from c4484f0 to b41d2aa Compare March 25, 2026 06:43
@sonallux sonallux force-pushed the fix/23324-openApiNullable-with-useJackson3 branch from b41d2aa to b0c2f39 Compare March 25, 2026 14:45
@sonallux
Copy link
Copy Markdown
Contributor Author

@wing328 die failing tests in "Samples JAX-RS" seem unrelated to me. I am also not getting any new changes when running the generate samples script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SPRING] support option openApiNullable with useJackson3

2 participants