feat(spring): enable openApiNullable with useJackson3#23331
Open
sonallux wants to merge 2 commits intoOpenAPITools:masterfrom
Open
feat(spring): enable openApiNullable with useJackson3#23331sonallux wants to merge 2 commits intoOpenAPITools:masterfrom
openApiNullable with useJackson3#23331sonallux wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
d6aa46c to
c4484f0
Compare
openApiNullable with useJackson3openApiNullable with useJackson3
Contributor
There was a problem hiding this comment.
No issues found across 296 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Member
|
thanks for the PR please review the build failure when you've time cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08) |
c4484f0 to
b41d2aa
Compare
b41d2aa to
b0c2f39
Compare
Contributor
Author
|
@wing328 die failing tests in "Samples JAX-RS" seem unrelated to me. I am also not getting any new changes when running the generate samples script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23324
openApiNullableis not allowed withuseJackson3. PR feature(jackson3) add jackson3 support for spring generator #22854 introduced this constraint, because no Jackson 3 compatible version ofjackson-databind-nullablewas availablejackson-databind-nullableto version0.2.10which supports both Jackson 2 and Jackson 3 (see PR Implement Jackson3 support and maintain Jackson2 support jackson-databind-nullable#117)PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)