Skip to content

Feature/fix speed bottlenecks 2#23341

Draft
Picazsoo wants to merge 23 commits intoOpenAPITools:masterfrom
Picazsoo:feature/fix-speed-bottlenecks-2
Draft

Feature/fix speed bottlenecks 2#23341
Picazsoo wants to merge 23 commits intoOpenAPITools:masterfrom
Picazsoo:feature/fix-speed-bottlenecks-2

Conversation

@Picazsoo
Copy link
Copy Markdown
Contributor

@Picazsoo Picazsoo commented Mar 24, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Improve code generation speed by cutting regex overhead and disk I/O. Precompiled shared patterns and a template content cache reduce repeated work; batch runs now print total duration, with standardized changes across many generators and fixes to placeholder/path handling.

  • New Features

    • Added elapsed time logging to GenerateBatch (mm ss ms).
  • Refactors

    • Centralized shared precompiled regex patterns and helpers in DefaultCodegen and PatternCache; replaced many replaceAll/matches/split with cached patterns or String.replace.
    • Standardized path parameter, placeholder, and escaping logic across generators (e.g., Go/Erlang/PHP/Java/JS/Ruby), fixing edge cases and reducing backtracking.
    • Minor cleanups and correctness tweaks (immutability, consistent sanitizers like STARTS_WITH_DIGIT/ALL_UPPER_UNDERSCORE, precompiled DOT/MINUS, newline splitting).

Written for commit a0172e1. Summary will update on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant