Skip to content

[csharp][generichost] Fix TokenBase race condition #23356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into from
Mar 27, 2026
Merged

[csharp][generichost] Fix TokenBase race condition #23356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dbb941
listen to your ai overlords
devhl-labs Mar 26, 2026
b954a0f
merge master
devhl-labs Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/openapi-generator/src/main/resources/csharp/libraries/generichost/TokenBase.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace {{packageName}}.{{clientPackage}}
{{>visibility}} abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -59,7 +59,7 @@ namespace {{packageName}}.{{clientPackage}}
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -73,8 +73,8 @@ namespace {{packageName}}.{{clientPackage}}

private void OnTimer(object{{nrt?}} sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions .../petstore/csharp/generichost/latest/ComposedEnum/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -64,7 +64,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -78,8 +78,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...nt/petstore/csharp/generichost/latest/HelloWorld/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -64,7 +64,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -78,8 +78,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...tstore/csharp/generichost/latest/InlineEnumAnyOf/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -64,7 +64,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -78,8 +78,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...ent/petstore/csharp/generichost/latest/OneOfList/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -64,7 +64,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -78,8 +78,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...s/client/petstore/csharp/generichost/latest/Tags/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -65,7 +65,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -79,8 +79,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...tore/csharp/generichost/latest/UseDateTimeOffset/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -64,7 +64,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -78,8 +78,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...s/client/petstore/csharp/generichost/net10/AllOf/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -64,7 +64,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -78,8 +78,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...s/client/petstore/csharp/generichost/net10/AnyOf/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -64,7 +64,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -78,8 +78,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...petstore/csharp/generichost/net10/AnyOfNoCompare/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -64,7 +64,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -78,8 +78,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...ent/petstore/csharp/generichost/net10/FormModels/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -62,7 +62,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -76,8 +76,8 @@ public void BeginRateLimit()

private void OnTimer(object sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...tore/csharp/generichost/net10/NullReferenceTypes/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -64,7 +64,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -78,8 +78,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
8 changes: 4 additions & 4 deletions ...s/client/petstore/csharp/generichost/net10/OneOf/src/Org.OpenAPITools/Client/TokenBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Org.OpenAPITools.Client
public abstract class TokenBase
{
private DateTime _nextAvailable = DateTime.UtcNow;
private object _nextAvailableLock = new object();
private readonly object _nextAvailableLock = new object();
private readonly System.Timers.Timer _timer = new System.Timers.Timer();

internal TimeSpan? Timeout { get; set; }
Expand Down Expand Up @@ -64,7 +64,7 @@ internal void StartTimer(TimeSpan timeout)
/// <summary>
/// Returns true while the token is rate limited.
/// </summary>
public bool IsRateLimited => _nextAvailable > DateTime.UtcNow;
public bool IsRateLimited { get { lock (_nextAvailableLock) return _nextAvailable > DateTime.UtcNow; } }

/// <summary>
/// Triggered when the server returns status code TooManyRequests
Expand All @@ -78,8 +78,8 @@ public void BeginRateLimit()

private void OnTimer(object? sender, System.Timers.ElapsedEventArgs e)
{
if (TokenBecameAvailable != null && !IsRateLimited)
TokenBecameAvailable.Invoke(this);
if (!IsRateLimited)
TokenBecameAvailable?.Invoke(this);
}
}
}
Loading
Loading