Skip to content

[JAVA-SPRING;KOTLIN-SPRING] feature - add support for 'substituteGenericPagedModel' also for 'spring-cloud' libraries#23690

Merged
wing328 merged 10 commits intoOpenAPITools:masterfrom
Picazsoo:feature/add-pagedmodel-support-to-spring-cloud
May 5, 2026
Merged

[JAVA-SPRING;KOTLIN-SPRING] feature - add support for 'substituteGenericPagedModel' also for 'spring-cloud' libraries#23690
wing328 merged 10 commits intoOpenAPITools:masterfrom
Picazsoo:feature/add-pagedmodel-support-to-spring-cloud

Conversation

@Picazsoo
Copy link
Copy Markdown
Contributor

@Picazsoo Picazsoo commented May 4, 2026

enable substituteGenericPagedModel feature also for spring-cloud libraries in java spring and kotlin spring code gens as there is no practical reason to forbid it.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. - kotlin - @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10) @dennisameling (2026/02); java-spring -@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

Summary by cubic

Adds substituteGenericPagedModel support for spring-cloud in both spring and kotlin-spring, removing the prior library restriction and updating docs. When enabled, paginated schemas are replaced with PagedModel<T>, and the original page/pagination models are not generated.

  • New Features
    • Respects importMappings.PagedModel; only generates the PagedModel supporting file when no custom mapping is set.
    • Docs: remove the note limiting this feature to specific libraries.

Written for commit af829fd. Summary will update on new commits.

@Picazsoo Picazsoo marked this pull request as ready for review May 4, 2026 16:32
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="CI/circle_parallel.sh">

<violation number="1">
P2: `sudo apt-get install libcpprest-dev` is missing the `-y` flag, which can cause the CI step to hang on a confirmation prompt in CircleCI's non-interactive environment.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

@wing328 wing328 merged commit 60ef743 into OpenAPITools:master May 5, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants