Skip to content

PowerShell: fix enum string starting with a number#23715

Merged
wing328 merged 4 commits intomasterfrom
powershell-enum
May 7, 2026
Merged

PowerShell: fix enum string starting with a number#23715
wing328 merged 4 commits intomasterfrom
powershell-enum

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented May 7, 2026

to close #21769

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Generate valid PowerShell enum member names when values start with digits by treating any leading-digit value as numeric and prefixing names (e.g., NUMBER_0).
Update the 3.0 Petstore spec and regenerate samples to add OuterEnumStringStartingWithNumber ('0', '1', '2'), with docs and a stub test.

Written for commit 318e0c9. Summary will update on new commits.

@wing328 wing328 changed the title add tests for enum string starting with integers Powershell: fix enum string starting with a number May 7, 2026
@wing328 wing328 marked this pull request as ready for review May 7, 2026 07:58
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

@wing328 wing328 changed the title Powershell: fix enum string starting with a number PowerShell: fix enum string starting with a number May 7, 2026
@wing328 wing328 merged commit 8d357f9 into master May 7, 2026
18 checks passed
@wing328 wing328 deleted the powershell-enum branch May 7, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [PowerShell] enum label must not start with a digit

1 participant