Skip to content

fix(189pc): handle numeric res_code in RenameResp to fix JSON unmarshal error #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyxjjj merged 3 commits into from
May 25, 2026
Merged

fix(189pc): handle numeric res_code in RenameResp to fix JSON unmarshal error #2489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f82ed7
fix(driver): fix 189 pc ResCode to any type
PIKACHUIM May 19, 2026
ffdef84
Merge branch 'main' into fix-189pc
PIKACHUIM May 19, 2026
938fa5d
Merge branch 'main' into fix-189pc
PIKACHUIM May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/189pc/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ func (y *Cloud189PC) Rename(ctx context.Context, srcObj model.Obj, newName strin
req.SetContext(ctx).SetQueryParams(queryParam)
}, nil, resp, isFamily)
if err != nil {
if resp.ResCode == "FileAlreadyExists" {
if code, ok := resp.ResCode.(string); ok && code == "FileAlreadyExists" {
return nil, errs.ObjectAlreadyExists
}
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion drivers/189pc/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ type RenameResp struct {
ParentID int64 `json:"parentId"`
Rev string `json:"rev"`
Size int64 `json:"size"`
ResCode string `json:"res_code"`
ResCode any `json:"res_code"` // int or string
}

func (r *RenameResp) toFile(f *Cloud189File) *Cloud189File {
Expand Down
Loading