Backport #2301

[Mab879]

No description provided.

[Mab879]

Seems localtime_s is POSIX, not C standard. I will need to review.

[jan-cerny]

Windows has localtime_s https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/localtime-s-localtime32-s-localtime64-s?view=msvc-170 , Unix has localtime_r. Ideally, you would define a wrapper function like oscap_localtime which would contain preprocessor macros (#ifdef WINDOWS) that would choose one of these functions based at compile time according to target platform. Then, you would use the oscap_localtime everywhere where localtime is called.

I think it isn't probably worth the effort and we can live with having the fix only in the main branch where we don't need to solve Windows.

[Mab879]

Windows has localtime_s https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/localtime-s-localtime32-s-localtime64-s?view=msvc-170 , Unix has localtime_r. Ideally, you would define a wrapper function like oscap_localtime which would contain preprocessor macros (#ifdef WINDOWS) that would choose one of these functions based at compile time according to target platform. Then, you would use the oscap_localtime everywhere where localtime is called.

I think it isn't probably worth the effort and we can live with having the fix only in the main branch where we don't need to solve Windows.

Agreed, closing.