feat(promo-codes): domain-authorized promo codes for early registration access #525
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1575,4 +1575,66 @@ public function sendSponsorPromoCodes($summit_id) | |
| return $this->ok(); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Discover qualifying promo codes for the current user. | ||
| * Returns domain-authorized codes (matched by email domain) and existing email-linked | ||
| * codes (member/speaker, matched by associated email) with auto_apply flag. | ||
| * Email is always derived from the authenticated principal — no email query parameter accepted. | ||
| */ | ||
| #[OA\Get( | ||
| path: "/api/v1/summits/{id}/promo-codes/all/discover", | ||
| summary: "Discover qualifying promo codes for the current user", | ||
| description: "Returns domain-authorized promo codes (matched by email domain) and existing email-linked promo codes (member/speaker, matched by associated email) for the current user", | ||
| operationId: "discoverPromoCodesBySummit", | ||
| tags: ["Promo Codes"], | ||
| security: [['summit_promo_codes_oauth2' => [SummitScopes::ReadSummitData]]], | ||
| parameters: [ | ||
| new OA\Parameter(name: "id", in: "path", required: true, schema: new OA\Schema(type: "integer")), | ||
| new OA\Parameter(name: "expand", in: "query", required: false, schema: new OA\Schema(type: "string")), | ||
| ], | ||
| responses: [ | ||
| new OA\Response(response: Response::HTTP_OK, description: "OK"), | ||
| new OA\Response(response: Response::HTTP_UNAUTHORIZED, description: "Unauthorized"), | ||
| new OA\Response(response: Response::HTTP_FORBIDDEN, description: "Forbidden"), | ||
| new OA\Response(response: Response::HTTP_NOT_FOUND, description: "Summit not found"), | ||
| ] | ||
| )] | ||
| public function discover($summit_id) | ||
| { | ||
| return $this->processRequest(function () use ($summit_id) { | ||
|
|
||
| $summit = SummitFinderStrategyFactory::build($this->summit_repository, $this->resource_server_context)->find(intval($summit_id)); | ||
| if (is_null($summit)) | ||
| return $this->error404(); | ||
|
|
||
| $current_member = $this->resource_server_context->getCurrentUser(); | ||
| if (is_null($current_member)) | ||
| return $this->error403(); | ||
|
|
||
| $codes = $this->promo_code_service->discoverPromoCodes($summit, $current_member); | ||
|
|
||
| $expand = Request::input('expand', ''); | ||
|
Collaborator
There was a problem hiding this comment. @caseylocker this not follow api patterns please check other controllers to see how we are doing it SerializerUtils::getExpand(),
SerializerUtils::getFields(),
SerializerUtils::getRelations()
Contributor
Author
There was a problem hiding this comment. Updated in c4bcdef. The |
||
| $fields = Request::input('fields', ''); | ||
| $relations = Request::input('relations', ''); | ||
|
|
||
| $relations = !empty($relations) ? explode(',', $relations) : ['allowed_ticket_types', 'badge_features', 'tags', 'ticket_types_rules']; | ||
| $fields = !empty($fields) ? explode(',', $fields) : []; | ||
|
|
||
| $data = []; | ||
| foreach ($codes as $code) { | ||
| $serializer = SerializerRegistry::getInstance()->getSerializer($code); | ||
| $data[] = $serializer->serialize($expand, $fields, $relations); | ||
| } | ||
|
|
||
| $total = count($data); | ||
| return $this->ok([ | ||
| 'total' => $total, | ||
| 'per_page' => $total, | ||
| 'current_page' => 1, | ||
| 'last_page' => 1, | ||
| 'data' => $data, | ||
| ]); | ||
| }); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| <?php namespace ModelSerializers; | ||
| /** | ||
| * Copyright 2026 OpenStack Foundation | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| **/ | ||
|
|
||
| use models\summit\DomainAuthorizedSummitRegistrationDiscountCode; | ||
|
|
||
| /** | ||
| * Class DomainAuthorizedSummitRegistrationDiscountCodeSerializer | ||
| * @package ModelSerializers | ||
| */ | ||
| class DomainAuthorizedSummitRegistrationDiscountCodeSerializer | ||
| extends SummitRegistrationDiscountCodeSerializer | ||
| { | ||
| protected static $array_mappings = [ | ||
| 'AllowedEmailDomains' => 'allowed_email_domains:json_string_array', | ||
| 'QuantityPerAccount' => 'quantity_per_account:json_int', | ||
| 'AutoApply' => 'auto_apply:json_boolean', | ||
| ]; | ||
|
|
||
| protected static $allowed_relations = [ | ||
| 'allowed_ticket_types', | ||
| ]; | ||
|
|
||
| /** | ||
| * @param null $expand | ||
| * @param array $fields | ||
| * @param array $relations | ||
| * @param array $params | ||
| * @return array | ||
| */ | ||
| public function serialize($expand = null, array $fields = [], array $relations = [], array $params = []) | ||
| { | ||
| $code = $this->object; | ||
| if (!$code instanceof DomainAuthorizedSummitRegistrationDiscountCode) return []; | ||
| $values = parent::serialize($expand, $fields, $relations, $params); | ||
|
|
||
| // RE-ADD allowed_ticket_types (parent discount serializer unsets it). | ||
| // Check both relations (default serialization) and expand (explicit ?expand= request). | ||
| $needs_allowed_ticket_types = in_array('allowed_ticket_types', $relations) | ||
|
Collaborator
There was a problem hiding this comment. @caseylocker This silently compensates for a parent behavior that's undocumented. If the parent serializer changes, this will break without any error. Consider either overriding the parent behaviour more explicitly (resetting the parent's unset) or documenting why the parent SummitRegistrationDiscountCodeSerializer removes allowed_ticket_types and whether that should be changed there instead.
Contributor
Author
There was a problem hiding this comment. Fair flag. I dug into this — the parent's What was sloppy was that three subclasses (
Wire output is byte-identical; the contract is now explicit so a future edit to the parent can't silently break the children. |
||
| || (!empty($expand) && str_contains($expand, 'allowed_ticket_types')); | ||
| if ($needs_allowed_ticket_types && !isset($values['allowed_ticket_types'])) { | ||
| $ticket_types = []; | ||
| foreach ($code->getAllowedTicketTypes() as $ticket_type) { | ||
| $ticket_types[] = $ticket_type->getId(); | ||
| } | ||
| $values['allowed_ticket_types'] = $ticket_types; | ||
| } | ||
|
|
||
| // Transient remaining_quantity_per_account (set by service layer) | ||
| $values['remaining_quantity_per_account'] = $code->getRemainingQuantityPerAccount(); | ||
|
|
||
| return $values; | ||
| } | ||
|
|
||
| protected static $expand_mappings = [ | ||
| 'allowed_ticket_types' => [ | ||
| 'type' => \Libs\ModelSerializers\Many2OneExpandSerializer::class, | ||
| 'getter' => 'getAllowedTicketTypes', | ||
| ], | ||
| ]; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <?php namespace ModelSerializers; | ||
| /** | ||
| * Copyright 2026 OpenStack Foundation | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| **/ | ||
|
|
||
| use models\summit\DomainAuthorizedSummitRegistrationPromoCode; | ||
|
|
||
| /** | ||
| * Class DomainAuthorizedSummitRegistrationPromoCodeSerializer | ||
| * @package ModelSerializers | ||
| */ | ||
| class DomainAuthorizedSummitRegistrationPromoCodeSerializer | ||
| extends SummitRegistrationPromoCodeSerializer | ||
| { | ||
| protected static $array_mappings = [ | ||
| 'AllowedEmailDomains' => 'allowed_email_domains:json_string_array', | ||
| 'QuantityPerAccount' => 'quantity_per_account:json_int', | ||
| 'AutoApply' => 'auto_apply:json_boolean', | ||
| ]; | ||
|
|
||
| /** | ||
| * @param null $expand | ||
| * @param array $fields | ||
| * @param array $relations | ||
| * @param array $params | ||
| * @return array | ||
| */ | ||
| public function serialize($expand = null, array $fields = [], array $relations = [], array $params = []) | ||
| { | ||
| $code = $this->object; | ||
| if (!$code instanceof DomainAuthorizedSummitRegistrationPromoCode) return []; | ||
| $values = parent::serialize($expand, $fields, $relations, $params); | ||
|
|
||
| // Transient remaining_quantity_per_account (set by service layer) | ||
| $values['remaining_quantity_per_account'] = $code->getRemainingQuantityPerAccount(); | ||
|
|
||
| return $values; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.