Skip to content

Add tunable_vector std::vector wrapper container#746

Open
Spartan322 wants to merge 1 commit into
masterfrom
add/tunable-vector
Open

Add tunable_vector std::vector wrapper container#746
Spartan322 wants to merge 1 commit into
masterfrom
add/tunable-vector

Conversation

@Spartan322
Copy link
Copy Markdown
Member

@Spartan322 Spartan322 commented May 20, 2026

Add tunable_vector memory alias to core/memory

@Spartan322 Spartan322 added enhancement New feature or request topic:core labels May 20, 2026
@Spartan322 Spartan322 force-pushed the add/stl-like-containers branch from 0c289ed to b2c561e Compare May 20, 2026 16:39
@Spartan322 Spartan322 force-pushed the add/tunable-vector branch from d00c51f to 27db712 Compare May 20, 2026 16:40
@wvpm
Copy link
Copy Markdown
Contributor

wvpm commented May 20, 2026

Add tunable_vector memory alias to core/memory

It shouldn't depend on that based on the code I read.
And it adds the entire type, not merely an alias.
Still nice draft.

Comment thread src/openvic-simulation/core/stl/containers/TunableVector.hpp Outdated
Comment thread src/openvic-simulation/core/stl/containers/TunableVector.hpp Outdated
Comment thread src/openvic-simulation/core/stl/containers/TunableVector.hpp Outdated
Comment thread src/openvic-simulation/core/stl/containers/TunableVector.hpp
@Spartan322 Spartan322 force-pushed the add/stl-like-containers branch 3 times, most recently from d4bc84c to db3fe7f Compare May 20, 2026 20:14
@Spartan322 Spartan322 force-pushed the add/tunable-vector branch from 27db712 to 9516014 Compare May 20, 2026 20:16
@Spartan322 Spartan322 force-pushed the add/stl-like-containers branch from db3fe7f to f94003a Compare May 20, 2026 22:57
@Spartan322
Copy link
Copy Markdown
Member Author

Add tunable_vector memory alias to core/memory

It shouldn't depend on that based on the code I read. And it adds the entire type, not merely an alias. Still nice draft.

It doesn't rely on any code from there but I set it to depend specifically because it relies on the organization from that PR. Also the alias description is saying what its doing, it does add a memory alias for the tunable_vector type, that's that is going on in core/memory

@Spartan322 Spartan322 force-pushed the add/tunable-vector branch 3 times, most recently from c6fa092 to 900c58b Compare May 20, 2026 23:26
@Spartan322 Spartan322 force-pushed the add/stl-like-containers branch from f94003a to 069ae75 Compare May 21, 2026 00:48
@Spartan322 Spartan322 force-pushed the add/tunable-vector branch from 900c58b to aa6c10a Compare May 21, 2026 00:49
@Spartan322 Spartan322 force-pushed the add/stl-like-containers branch from 069ae75 to ecb7ae0 Compare May 21, 2026 04:18
@Spartan322 Spartan322 force-pushed the add/tunable-vector branch from aa6c10a to f2b7c03 Compare May 21, 2026 04:19
@Spartan322 Spartan322 force-pushed the add/stl-like-containers branch from ecb7ae0 to b8ffe2c Compare May 21, 2026 04:30
@Spartan322 Spartan322 force-pushed the add/tunable-vector branch from f2b7c03 to 4e5d027 Compare May 21, 2026 04:30
@Spartan322 Spartan322 force-pushed the add/stl-like-containers branch from b8ffe2c to 8606610 Compare May 23, 2026 22:37
@Spartan322 Spartan322 force-pushed the add/stl-like-containers branch from 8606610 to fa0e42f Compare May 23, 2026 23:08
Base automatically changed from add/stl-like-containers to master May 23, 2026 23:14
@Spartan322 Spartan322 force-pushed the add/tunable-vector branch 2 times, most recently from 3be9724 to ec3186f Compare May 23, 2026 23:49
@Spartan322 Spartan322 marked this pull request as ready for review May 24, 2026 13:46
@Spartan322 Spartan322 requested a review from a team as a code owner May 24, 2026 13:46
Comment thread src/openvic-simulation/core/stl/containers/TunableVector.hpp Outdated
};

template<typename Range, typename T>
concept _compatible_range =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/OpenVicProject/OpenVic-Simulation/pull/754/changes#diff-66b217c20a8a9c4dcc694b0c9515140cafa6b47f01a4aaa7127fba1c129ef66c

Does the same. This is a common concern.
We can leave it here for now and replace it with RangeConcepts.hpp once that's merged.
Alternatively, feel free to extract it now in case we need it for other PRs as well.

Comment thread src/openvic-simulation/core/stl/containers/TunableVector.hpp Outdated
Comment thread src/openvic-simulation/core/stl/containers/TunableVector.hpp
Comment thread src/openvic-simulation/core/stl/containers/TunableVector.hpp
Copy link
Copy Markdown
Contributor

@wvpm wvpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see unit tests.

@Spartan322 Spartan322 force-pushed the add/tunable-vector branch from ec3186f to f61ed8a Compare May 24, 2026 21:24
Add tunable_vector memory alias to `core/memory`
@Spartan322 Spartan322 force-pushed the add/tunable-vector branch from f61ed8a to 7c5d47f Compare May 25, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request topic:core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants