Skip to content

Remove deprecated ldapname fact option and accessor#111

Open
silug wants to merge 1 commit into
OpenVoxProject:mainfrom
silug:remove-ldapname
Open

Remove deprecated ldapname fact option and accessor#111
silug wants to merge 1 commit into
OpenVoxProject:mainfrom
silug:remove-ldapname

Conversation

@silug
Copy link
Copy Markdown

@silug silug commented Apr 13, 2026

Short description

The ldapname feature was deprecated with a runtime warning. This commit completes the removal per OpenVox Platform Deprecation Schedule (issue #87):

  • Remove ldapname attr_accessor from Facter::Util::Fact
  • Remove extract_ldapname_option! method and its call in initialize
  • Remove forwarding call to extract_ldapname_option! in Collection#create_or_return_fact
  • Remove associated tests

Closes #87

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document and added a Signed-off-by annotation to each of my commits
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

The ldapname feature was deprecated with a runtime warning. This commit
completes the removal per OpenVox Platform Deprecation Schedule (issue OpenVoxProject#87):

- Remove `ldapname` attr_accessor from Facter::Util::Fact
- Remove `extract_ldapname_option!` method and its call in initialize
- Remove forwarding call to extract_ldapname_option! in Collection#create_or_return_fact
- Remove associated tests

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
@silug silug marked this pull request as ready for review April 24, 2026 21:06
@silug silug added the backwards-incompatible This change will lead to a major version bump for the next release label Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompatible This change will lead to a major version bump for the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Deprecation] ldapname Fact Option and Accessor

1 participant