Deprecate time_limit and limit timeout aliases in Facter::Core::Execution.execute#114
Open
silug wants to merge 1 commit into
Open
Deprecate time_limit and limit timeout aliases in Facter::Core::Execution.execute#114silug wants to merge 1 commit into
silug wants to merge 1 commit into
Conversation
…tion.execute These option keys are compatibility aliases for `:timeout`. Emit a specific `warnonce` deprecation message for each when used, rather than surfacing them through the generic unexpected-key warning. Closes OpenVoxProject#90 Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Signed-off-by: Steven Pritchard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
These option keys are compatibility aliases for
:timeout. Emit a specificwarnoncedeprecation message for each when used, rather than surfacing them through the generic unexpected-key warning.Closes #90
Checklist
I have:
Signed-off-byannotation to each of my commits