Skip to content

build from the latest release tag#236

Merged
binford2k merged 1 commit into
OpenVoxProject:masterfrom
binford2k:fix_tag_logic
May 21, 2026
Merged

build from the latest release tag#236
binford2k merged 1 commit into
OpenVoxProject:masterfrom
binford2k:fix_tag_logic

Conversation

@binford2k
Copy link
Copy Markdown
Contributor

This expects all versions to match semver specifications. It will throw
away all tags that don't properly parse and filter out pre-releases.

@binford2k binford2k requested a review from a team as a code owner May 21, 2026 21:52
@binford2k binford2k force-pushed the fix_tag_logic branch 4 times, most recently from 71ed8cb to 2ba1eec Compare May 21, 2026 22:12
This expects all versions to match semver specifications. It will throw
away all tags that don't properly parse and filter out pre-releases.

Signed-off-by: Ben Ford <[email protected]>
@binford2k
Copy link
Copy Markdown
Contributor Author

wtf rubocop. How exactly is THIS readable?

def newest_release
      @repo.tags.map { |t| Gem::Version.new(t.name) rescue Gem::Version.new(0) } # rubocop:disable Style/RescueModifier
                .reject(&:prerelease?)
           .max
           .version
    end

@binford2k binford2k merged commit 959a613 into OpenVoxProject:master May 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants