[Minor] Range.Maximum/Minimum#2227
Open
Coronia wants to merge 1 commit into
Open
Conversation
Coronia
added
Minor
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Contributor
The proper approach should be to make ProjectileRange support RangeMultiplier. |
| AttachEffect.DisallowedMaxCounts= ; integer - maximum disallowed instance count (comma-separated) for cumulative types in order from first to last. | ||
| AttachEffect.IgnoreFromSameSource=false ; boolean | ||
| AttachEffect.CheckOnFirer=false ; boolean | ||
| Range.Maximum=2147483647 ; integer |
Collaborator
There was a problem hiding this comment.
Perhaps they are suitable for using the same series of prefixes in tag names?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There're cases when we don't want weapon range AE or other range modifiers to change weapon's range infinitely. F.ex. if it's longer than the weapon's
ProjectileRangeit'll fail to hit the target beyond that. Adding a setting on weapon for theses cases to define the maximum/minimum value of its range