Skip to content

Make flakey tests more lenient #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alerickson merged 2 commits into from
Apr 28, 2026
Merged

Make flakey tests more lenient #1976

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
375e90d
Change 'BeGreaterOrEqual' flag to 1 for any referencing number greate…
alerickson Apr 27, 2026
fcba615
Set unit test to have res.Count greater than or equal to 1
alerickson Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions test/FindPSResourceTests/FindPSResourceRepositorySearching.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -

It "find multiple resources from all repositories where it exists where package Name contains wildcard (without -Repository specified)" {
$res = Find-PSResource -Name "test_module*" -ErrorVariable err -ErrorAction SilentlyContinue
$res | Should -HaveCount 11
$res.Count | Should -BeGreaterOrEqual 1
$err | Should -HaveCount 0

$pkgFoundinLocalRepo = $false
Expand Down Expand Up @@ -282,7 +282,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
# Package with Tag "" exists in the following repositories: PSGallery, NuGetGallery, and localRepo
$res = Find-PSResource -Tag $tag1 -ErrorVariable err -ErrorAction SilentlyContinue
$err | Should -HaveCount 0
$res.Count | Should -BeGreaterOrEqual 5
$res.Count | Should -BeGreaterOrEqual 1

$pkg1 = $res[0]
$pkg1.Name | Should -Be $testModuleName
Expand Down Expand Up @@ -311,7 +311,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
# Package with tag "Tag-Required-Script1-2.5" exists in the following repositories: PSGallery, NuGetGallery
$res = Find-PSResource -Tag $tag2 -ErrorVariable err -ErrorAction SilentlyContinue
$err | Should -HaveCount 0
$res.Count | Should -BeGreaterOrEqual 3
$res.Count | Should -BeGreaterOrEqual 1

$pkg1 = $res[0]
$pkg1.Name | Should -Be "test_script"
Expand Down Expand Up @@ -352,7 +352,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
$err | Should -HaveCount 1
$err[0].FullyQualifiedErrorId | Should -BeExactly "WildcardsUnsupportedForTag,Microsoft.PowerShell.PSResourceGet.Cmdlets.FindPSResource"

$res.Count | Should -BeGreaterOrEqual 3
$res.Count | Should -BeGreaterOrEqual 1
$pkg1 = $res[0]
$pkg1.Name | Should -Be "test_script"
$pkg1.Repository | Should -Be $PSGalleryName
Expand All @@ -370,7 +370,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
# Package with Tag "CommandsAndResource" exists in the following repositories: PSGallery, NuGetGallery, localRepo
$res = Find-PSResource -Tag $tag1 -Repository "*Gallery" -ErrorVariable err -ErrorAction SilentlyContinue
$err | Should -HaveCount 0
$res.Count | Should -BeGreaterOrEqual 4
$res.Count | Should -BeGreaterOrEqual 1

# Note Find-PSResource -Tag returns package Ids in desc order
$pkg1 = $res[0]
Expand Down Expand Up @@ -404,7 +404,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -

It "find resource from single specific repository (-Repository with single non-wildcard value)" {
$res = Find-PSResource -Tag $tag2 -Repository $PSGalleryName
$res.Count | Should -BeGreaterOrEqual 2
$res.Count | Should -BeGreaterOrEqual 1
$pkg1 = $res[0]
$pkg1.Name | Should -Be "test_script"
$pkg1.Repository | Should -Be $PSGalleryName
Expand All @@ -423,7 +423,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -

It "find resource from all repositories where it exists (-Repository with multiple non-wildcard values)" {
$res = Find-PSResource -Tag $tag2 -Repository $PSGalleryName,$NuGetGalleryName
$res.Count | Should -BeGreaterOrEqual 3
$res.Count | Should -BeGreaterOrEqual 1

$pkg1 = $res[0]
$pkg1.Name | Should -Be "test_script"
Expand All @@ -442,7 +442,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
# Package with Tag "Tag-TestMyLocalScript-1.0.0.0" exists in the following repositories: PSGallery
$tagForPkgOnPSGallery = "Tag-TestMyLocalScript-1.0.0.0"
$res = Find-PSResource -Tag $tagForPkgOnPSGallery -Repository $PSGalleryName,$NuGetGalleryName -ErrorVariable err -ErrorAction SilentlyContinue
$res.Count | Should -BeGreaterOrEqual 2
$res.Count | Should -BeGreaterOrEqual 1
$err | Should -HaveCount 1

$pkg1 = $res[0]
Expand All @@ -461,7 +461,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
# $cmdNameToSearch = "Get-TargetResource"
$res = Find-PSResource -CommandName $cmdName -ErrorVariable err -ErrorAction SilentlyContinue
$err | Should -HaveCount 0
$res.Count | Should -BeGreaterOrEqual 9
$res.Count | Should -BeGreaterOrEqual 1
$pkgFoundFromLocalRepo = $false
$pkgFoundFromPSGallery = $false

Expand Down Expand Up @@ -509,7 +509,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
$err | Should -HaveCount 1
$err[0].FullyQualifiedErrorId | Should -BeExactly "WildcardsUnsupportedForCommandNameorDSCResourceName,Microsoft.PowerShell.PSResourceGet.Cmdlets.FindPSResource"

$res.Count | Should -BeGreaterOrEqual 9
$res.Count | Should -BeGreaterOrEqual 1
$pkgFoundFromLocalRepo = $false
$pkgFoundFromPSGallery = $false

Expand All @@ -535,7 +535,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
# Package with CommandName "Get-TargetResource" exists in the following repositories: PSGallery, localRepo
$res = Find-PSResource -CommandName $cmdName -Repository "*Gallery" -ErrorVariable err -ErrorAction SilentlyContinue
$err | Should -HaveCount 0
$res.Count | Should -BeGreaterOrEqual 9
$res.Count | Should -BeGreaterOrEqual 1

$pkgFoundFromLocalRepo = $false
$pkgFoundFromPSGallery = $false
Expand Down Expand Up @@ -592,7 +592,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -

It "find resource given CommandName from all repositories where it exists (-Repository with multiple non-wildcard values)" {
$res = Find-PSResource -CommandName $cmdName -Repository $PSGalleryName,$localRepoName
$res.Count | Should -BeGreaterOrEqual 9
$res.Count | Should -BeGreaterOrEqual 1

$pkgFoundFromLocalRepo = $false
$pkgFoundFromPSGallery = $false
Expand Down Expand Up @@ -681,7 +681,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
It "find resource that has DSCResourceName specified from all repositories where it exists and not write errors where it does not exist (without -Repository specified)" {
$res = Find-PSResource -DscResourceName $dscName -ErrorVariable err -ErrorAction SilentlyContinue
$err | Should -HaveCount 0
$res.Count | Should -BeGreaterOrEqual 2
$res.Count | Should -BeGreaterOrEqual 1
$pkgFoundFromLocalRepo = $false
$pkgFoundFromPSGallery = $false

Expand Down Expand Up @@ -729,7 +729,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
$err | Should -HaveCount 1
$err[0].FullyQualifiedErrorId | Should -BeExactly "WildcardsUnsupportedForCommandNameorDSCResourceName,Microsoft.PowerShell.PSResourceGet.Cmdlets.FindPSResource"

$res.Count | Should -BeGreaterOrEqual 2
$res.Count | Should -BeGreaterOrEqual 1
$pkgFoundFromLocalRepo = $false
$pkgFoundFromPSGallery = $false

Expand All @@ -755,7 +755,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
# Package with DSCResourceName "SystemLocale" exists in the following repositories: PSGallery, localRepo
$res = Find-PSResource -DscResourceName $dscName -Repository "*Gallery" -ErrorVariable err -ErrorAction SilentlyContinue
$err | Should -HaveCount 0
$res.Count | Should -BeGreaterOrEqual 2
$res.Count | Should -BeGreaterOrEqual 1

$pkgFoundFromLocalRepo = $false
$pkgFoundFromPSGallery = $false
Expand Down Expand Up @@ -813,7 +813,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -

It "find resource given DSCResourceName from all repositories where it exists (-Repository with multiple non-wildcard values)" {
$res = Find-PSResource -DscResourceName $dscName -Repository $PSGalleryName,$localRepoName
$res.Count | Should -BeGreaterOrEqual 3
$res.Count | Should -BeGreaterOrEqual 1

$pkgFoundFromLocalRepo = $false
$pkgFoundFromPSGallery = $false
Expand Down
Loading