Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2503 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 41 41
Lines 3066 3092 +26
Branches 662 668 +6
=======================================
+ Hits 3040 3066 +26
Misses 14 14
Partials 12 12 🚀 New features to boost your workflow:
|
7a1baf9 to
ae33151
Compare
|
@copilot Fix review |
a0989a7 to
57d0a13
Compare
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
57d0a13 to
07d3275
Compare
DanielNoord
left a comment
There was a problem hiding this comment.
Only DeepSource fails, but that is a stupid test anyway...
@staticdev Do you have some time to review this? I think it is actually in quite a good state now.
My plan is to merge this and release a beta version of isort. I will announce this on the original PEP thread in Discourse (and other channels if I find them) to see if users have initial feedback.
After a while we can then release an actual version. Probably somewhat after the first beta of Python 3.15.
|
@DanielNoord I started reading the peps to better understand how the lazy imports will work. I will put a bit more effort to keep up and it is very cool you were already able to do some testing. This one is a big one, congratulations already for your efforts. I will do my best to start with the code ASAP. |
I think for now we should just mimic the behaviour of The PEP doesn't say anything about preferred sorting order, but the order |
Gooiemorgen, |
|
See astral-sh/ruff#21305 :) |
|
I also took their example and used it as a test case in our code! |
Asked Copilot to create a first attempt at #2462
It will require some polishing, especially in the tests. However, the approach seems sensible to me. @staticdev what do you think of this direction?