Merged
Conversation
codeguru42
force-pushed
the
cpython-internal-apis
branch
from
7a5fee9 to
f99aba0
Compare
codeguru42
force-pushed
the
cpython-internal-apis
branch
from
f99aba0 to
87f688b
Compare
davidhewitt
reviewed
Apr 11, 2026
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, I think we can (and should) be a little bit more aggressive with the removals since these are CPython private symbols.
| note = "`_PySet_NextEntry` is a CPython-internal API with no stability guarantee; iterate sets using `PyObject_GetIter` / `PyIter_Next` instead" | ||
| )] | ||
| #[cfg_attr(PyPy, link_name = "_PyPySet_NextEntry")] | ||
| pub fn _PySet_NextEntry( |
Member
There was a problem hiding this comment.
I think we can just immediately remove this; the private definitions have no stability guarantees.
Contributor
Author
|
@davidhewitt back to you |
davidhewitt
approved these changes
Apr 12, 2026
Member
|
Thanks, looks good to me. To fix CI you'll need to remove the macro branch for |
Contributor
Author
|
@davidhewitt back to you again |
Member
|
Super, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up a few more
_Py*symbols per #3762. This may conflict with some changes in #5592, mostly because I am marking items as deprecated instead of removing. If we prefer to remove instead, I'll be happy to do so. Hopefully something here is helpful moving this forward.