Skip to content

fix: Make PartialMessage.edit work with CV2 views#3237

Open
ToothyDev wants to merge 8 commits into
masterfrom
fix/edit-partial-message
Open

fix: Make PartialMessage.edit work with CV2 views#3237
ToothyDev wants to merge 8 commits into
masterfrom
fix/edit-partial-message

Conversation

@ToothyDev
Copy link
Copy Markdown
Contributor

@ToothyDev ToothyDev commented May 23, 2026

Summary

PartialMessage.edit used to not check for CV2 views. This PR just makes it do that, and set the flags later accordingly, which now makes it behave equally to Message.edit as far as I tested

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

Closes #3236

@ToothyDev ToothyDev requested review from a team, JustaSqu1d and Paillat-dev May 23, 2026 13:28
@ToothyDev ToothyDev requested a review from a team as a code owner May 23, 2026 13:28
@github-project-automation github-project-automation Bot moved this to Todo in Pycord May 23, 2026
@pycord-app
Copy link
Copy Markdown

pycord-app Bot commented May 23, 2026

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3237/head:pr-3237
git checkout pr-3237

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3237/head

@ToothyDev ToothyDev requested a review from a team as a code owner May 23, 2026 13:30
@ToothyDev ToothyDev requested review from a team and EmmmaTech May 23, 2026 13:30
@ToothyDev ToothyDev changed the title Fix flags assignment when editing PartialMessages fix: Make PartialMessage.edit work with CV2 views May 23, 2026
Paillat-dev
Paillat-dev previously approved these changes May 23, 2026
NeloBlivion
NeloBlivion previously approved these changes May 23, 2026
@ToothyDev ToothyDev added the bug Something isn't working label May 23, 2026
Co-authored-by: NeloBlivion <41271523+neloblivion@users.noreply.github.com>
@ToothyDev ToothyDev changed the title fix: Make PartialMessage.edit work with CV2 views fix: Make PartialMessage.edit and Webhook.edit_message work with CV2 views May 24, 2026
@ToothyDev ToothyDev dismissed stale reviews from NeloBlivion and Paillat-dev via 2cec2f4 May 24, 2026 10:37
@ToothyDev ToothyDev linked an issue May 24, 2026 that may be closed by this pull request
3 tasks
@ToothyDev ToothyDev requested a review from NeloBlivion May 24, 2026 10:50
@ToothyDev ToothyDev requested a review from Paillat-dev May 24, 2026 10:50
Paillat-dev
Paillat-dev previously approved these changes May 24, 2026
Copy link
Copy Markdown
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just wait for nelo + squid

Comment thread discord/webhook/async_.py Outdated
@ToothyDev ToothyDev changed the title fix: Make PartialMessage.edit and Webhook.edit_message work with CV2 views fix: Make PartialMessage.edit work with CV2 views May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

PartialMessage.edit does not work with DesignerView (cv2)

4 participants