fix: Make PartialMessage.edit work with CV2 views#3237
Open
ToothyDev wants to merge 8 commits into
Open
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3237/head:pr-3237
git checkout pr-3237This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3237/head |
PartialMessage.edit work with CV2 views
Paillat-dev
previously approved these changes
May 23, 2026
NeloBlivion
previously approved these changes
May 23, 2026
Co-authored-by: NeloBlivion <41271523+neloblivion@users.noreply.github.com>
PartialMessage.edit work with CV2 viewsPartialMessage.edit and Webhook.edit_message work with CV2 views
3 tasks
Paillat-dev
previously approved these changes
May 24, 2026
Member
Paillat-dev
left a comment
There was a problem hiding this comment.
lgtm just wait for nelo + squid
plun1331
requested changes
May 24, 2026
3 tasks
This reverts commit 2cec2f4
PartialMessage.edit and Webhook.edit_message work with CV2 viewsPartialMessage.edit work with CV2 views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PartialMessage.editused to not check for CV2 views. This PR just makes it do that, and set the flags later accordingly, which now makes it behave equally toMessage.editas far as I testedInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.Closes #3236