Skip to content

feat(QOV-1891): add cluster DNS provider settings.#2674

Merged
rmnbrd merged 4 commits into
stagingfrom
feat/dns-provider-v2
May 13, 2026
Merged

feat(QOV-1891): add cluster DNS provider settings.#2674
rmnbrd merged 4 commits into
stagingfrom
feat/dns-provider-v2

Conversation

@pggb25
Copy link
Copy Markdown
Collaborator

@pggb25 pggb25 commented May 11, 2026

Summary

Add DNS provider settings page in the new cluster navigation
Support Qovery, Cloudflare, and Route53 configuration
Gate editing behind Enterprise plan and keep non-Enterprise view read-only
Use generated API client for DNS provider GET/PUT calls

more info here:
https://qovery.slack.com/archives/C090J2C2BUP/p1778051436737839

Issue:

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 42.18750% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.14%. Comparing base (d1539cd) to head (6692d4c).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...rovider-settings/cluster-dns-provider-settings.tsx 46.55% 21 Missing and 10 partials ⚠️
...e-cluster-dns-provider/use-cluster-dns-provider.ts 0.00% 3 Missing ⚠️
...ster-dns-provider/use-edit-cluster-dns-provider.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2674      +/-   ##
===========================================
+ Coverage    43.73%   46.14%   +2.41%     
===========================================
  Files          591     1150     +559     
  Lines        14532    23960    +9428     
  Branches      4264     6974    +2710     
===========================================
+ Hits          6355    11056    +4701     
- Misses        7046    10954    +3908     
- Partials      1131     1950     +819     
Flag Coverage Δ
unittests 46.14% <42.18%> (+2.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

const { mutateAsync: editClusterDnsProvider, isLoading: isEditClusterDnsProviderLoading } =
useEditClusterDnsProvider()

const isLoading = isOrganizationLoading || isClusterDnsProviderLoading
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of manually dealing with loading states, can you use React Suspense?
You can take example on this component:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pggb25 pggb25 force-pushed the feat/dns-provider-v2 branch from 000cbd1 to 8aa020a Compare May 11, 2026 15:02
pggb25 added 4 commits May 13, 2026 16:00
Description:

Add DNS provider settings page in the new cluster navigation
Support Qovery, Cloudflare, and Route53 configuration
Gate editing behind Enterprise plan and keep non-Enterprise view read-only
Use generated API client for DNS provider GET/PUT calls
@pggb25 pggb25 force-pushed the feat/dns-provider-v2 branch from 8aa020a to 6692d4c Compare May 13, 2026 14:02
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rmnbrd rmnbrd merged commit fed6600 into staging May 13, 2026
11 checks passed
@rmnbrd rmnbrd deleted the feat/dns-provider-v2 branch May 13, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants