Import orso project#231
Open
MikeSullivan7 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #170
This PR is a expansion on the proof of concept branch here which used AI produced code to show that an .ort file could be loaded in. There was a fair amount of bloat due to the AI, therefore the code as been cut down and streamlined.
The dialog to load in the .ort file has been merged with the exisiting RasCAL-1 import dialog where the separation of the files is done within the presenter.
There is now an
orso_importer.pyfile which deals with usingorsopyto load in the .ort file and then convert the data into a form which can be used within RasCAL-2. This also usesbilayer_utils.pywhich is a file of utility functions to extract and build bilayer information. This uses themolgroupslibrary to get revelant lipids information.The
molgroupsandrefll1dlibraries are new dependants, howeverrefl1dis pinned to1.0.0a1as this is the last version which is compatible with themolgroupslibrary.