fix: return comparison result in reply name uniqueness check#77
Merged
iam-vipin merged 1 commit intoRocketChat:mainfrom Mar 30, 2026
Merged
Conversation
The isUniqueReplyName method had a bug where the comparison replyFound.id === replyId was a standalone expression whose result was discarded, followed by unconditionally returning true. This allowed users to rename a reply to a name already used by another reply, bypassing the uniqueness validation. Fix: return the comparison result directly so the method correctly returns false when a different reply already has that name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
ReplyStorage.ts, theisUniqueReplyNamemethod has a no-op comparison:This means when editing a reply, the uniqueness check always passes — allowing a user to rename a reply to a name that's already used by another reply.
Fix
Return the comparison result directly:
This correctly returns true if the found reply is the same one being edited (user keeping their own name) and false if a different reply already has that name (blocking the duplicate)
Testing