Skip to content

a11y: demote tab-widget body from <main> to <div> #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
m5x5 wants to merge 1 commit into
base: post-milestone3m
Choose a base branch
from
+2 −2
Draft

a11y: demote tab-widget body from <main> to <div> #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export function tabWidget (options: TabWidgetOptions) {
const navElement = rootElement.appendChild(dom.createElement('nav'))
navElement.setAttribute('style', style.tabsNavElement)

const mainElement = rootElement.appendChild(dom.createElement('main'))
const mainElement = rootElement.appendChild(dom.createElement('div'))

mainElement.setAttribute('style', style.tabsMainElement) // override tabbedtab.css
const tabContainer = navElement.appendChild(dom.createElement('ul'))
Expand Down Expand Up @@ -333,7 +333,7 @@ export function tabWidget (options: TabWidgetOptions) {
function getOrCreateContainerElement (ele: TabElement): ContainerElement {
const bodyMain = ele.bodyTR?.children[0] as ContainerElement
if (bodyMain) return bodyMain
const newBodyMain = ele.bodyTR!.appendChild(dom.createElement('main'))
const newBodyMain = ele.bodyTR!.appendChild(dom.createElement('div'))
newBodyMain.setAttribute('style', bodyMainStyle)
return newBodyMain
}
Expand Down