Skip to content

🌐 Ship vi translations#1039

Closed
honhatduy wants to merge 3 commits intoTryGhost:mainfrom
honhatduy:main
Closed

🌐 Ship vi translations#1039
honhatduy wants to merge 3 commits intoTryGhost:mainfrom
honhatduy:main

Conversation

@honhatduy
Copy link
Copy Markdown

Based on en.json

Based on en.json
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 11a61bb0-b3b1-454f-b1c0-97017b90d34c

📥 Commits

Reviewing files that changed from the base of the PR and between 8a43226 and 053901a.

📒 Files selected for processing (1)
  • locales/vi.json
✅ Files skipped from review due to trivial changes (1)
  • locales/vi.json

Walkthrough

A new Vietnamese localization file (locales/vi.json) was added (+112 lines) containing key/value translations for UI strings. Entries cover pagination, issue/post discovery and status text, authentication/account flows, member/paid-access messaging (including tiered variants), navigation/menu/theme labels, and general UI actions. Multiple strings preserve runtime placeholders such as {page}, {totalPages}, {numberOfIssues}, {numberOfPosts}, {authors}, {primaryAuthor}, {tiers}, {sitetitle}, {ghostlink}, and {primaryTag}, as well as singular/plural and punctuation/arrow variants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title '🌐 Ship vi translations' clearly describes the main change: adding Vietnamese translations to the codebase.
Description check ✅ Passed The description 'Based on en.json' is related to the changeset, indicating the source of the Vietnamese translations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@locales/vi.json`:
- Line 92: The Vietnamese translation for the i18n key "This post is for
subscribers only" incorrectly uses the word for "page"; update the value for the
key "This post is for subscribers only" in locales/vi.json to use the correct
Vietnamese word for "post" (e.g., replace "Trang này chỉ dành cho thành viên"
with a phrasing using "bài viết" such as "Bài viết này chỉ dành cho thành viên")
so the UI shows the proper context in post-gated views.
- Line 31: The translation key in locales/vi.json uses a curly Unicode
apostrophe in "Don’t miss out on the latest issues. Sign up now to get access to
the library of members-only issues." which won't match Ghost's exact-string
lookup; update that key to use the straight ASCII apostrophe (i.e., "Don't miss
out...members-only issues.") so the JSON key exactly matches the source key used
by {{t}} and avoid fallback.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7a1a4c3-2350-4f4a-b83c-f79061d02ee1

📥 Commits

Reviewing files that changed from the base of the PR and between 6e22fbd and 0a37846.

📒 Files selected for processing (1)
  • locales/vi.json

Comment thread locales/vi.json
Comment thread locales/vi.json Outdated
Since this theme uses 'Topic', using 'Topic/Chủ đề' would be more accurate in Vietnamese.
@cathysarisky
Copy link
Copy Markdown
Member

Hi! As it says in the README, please make any translation contributions for ANY theme (including Source and Capser) over in the Themes repository. https://github.com/TryGhost/themes

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants