Conversation
Based on en.json
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughA new Vietnamese localization file ( Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@locales/vi.json`:
- Line 92: The Vietnamese translation for the i18n key "This post is for
subscribers only" incorrectly uses the word for "page"; update the value for the
key "This post is for subscribers only" in locales/vi.json to use the correct
Vietnamese word for "post" (e.g., replace "Trang này chỉ dành cho thành viên"
with a phrasing using "bài viết" such as "Bài viết này chỉ dành cho thành viên")
so the UI shows the proper context in post-gated views.
- Line 31: The translation key in locales/vi.json uses a curly Unicode
apostrophe in "Don’t miss out on the latest issues. Sign up now to get access to
the library of members-only issues." which won't match Ghost's exact-string
lookup; update that key to use the straight ASCII apostrophe (i.e., "Don't miss
out...members-only issues.") so the JSON key exactly matches the source key used
by {{t}} and avoid fallback.
Since this theme uses 'Topic', using 'Topic/Chủ đề' would be more accurate in Vietnamese.
|
Hi! As it says in the README, please make any translation contributions for ANY theme (including Source and Capser) over in the Themes repository. https://github.com/TryGhost/themes Thanks! |
Based on en.json