Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens _parse_grid_type format detection by introducing per-format helper checks and adds targeted tests to ensure supported formats are correctly identified while incomplete signals are rejected.
Changes:
- Added helper predicates (
_is_exodus,_is_scrip,_is_mpas, etc.) and refactored_parse_grid_typeto use them. - Expanded supported-format detection to include additional grid specs (e.g., GEOS-CS, ICON, FESOM2) via stricter checks.
- Added new unit tests covering supported formats, structured grids, and rejection of incomplete format signals.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
uxarray/io/utils.py |
Adds per-format detection helpers and refactors _parse_grid_type to use stricter, format-specific checks. |
test/io/test_utils.py |
Adds focused tests for correct format detection and for rejecting incomplete/ambiguous datasets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #238 by tightening internal grid format detection and adding focused parser tests.