third_party/setup.py: fix wabt platform detection on Linux#8526
Merged
kripken merged 1 commit intoWebAssembly:mainfrom Mar 26, 2026
Merged
third_party/setup.py: fix wabt platform detection on Linux#8526kripken merged 1 commit intoWebAssembly:mainfrom
kripken merged 1 commit intoWebAssembly:mainfrom
Conversation
BilelGho
force-pushed
the
fix-wabt-platform-detection
branch
2 times, most recently
from
c6bbf6d to
5d6a791
Compare
BilelGho
changed the title
wabt changed its release asset naming convention in 1.0.39. On Linux, the old name 'ubuntu' no longer matches the new names 'linux-x64' and 'linux-arm64', causing setup.py to silently fail with an empty download URL.
BilelGho
force-pushed
the
fix-wabt-platform-detection
branch
from
5d6a791 to
8091b37
Compare
kripken
approved these changes
Mar 26, 2026
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Thanks! I didn't remember we had this script...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wabt changed its release asset naming convention in version 1.0.39. On Linux, the old name
ubuntuno longer matches the new nameslinux-x64/linux-arm64, causingsetup.pyto silently fail with an empty download URL and crash withValueError: unknown url type: ''.The fix mirrors the existing style for
macosandwindows— returning a prefix that matches the asset name via the existing regex.