Merged
Conversation
tlively
approved these changes
Mar 26, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Rubberstamp LGTM. Sounds like you already checked that we hadn't added any extra tests that weren't present upstream, which is the only thing I would be concerned about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are all present and more up to date in the testsuite/ directory. In addition, none of these tests are skipped from the upstream. Manually checked the diff to confirm, and checking the diff summary confirms that the upstream tests are similar and more up to date: https://gist.github.com/stevenfontanella/873cc748168ad16f9a3ce4fb81a8bf2e.
Part of #8261.