Fix/legacy driver removal followup#362
Merged
JanJakes merged 2 commits intoremove-legacy-driverfrom Apr 15, 2026
Merged
Conversation
The catch block accessed $err->errorInfo[1] and $err->errorInfo[2], but WP_SQLite_Driver_Exception (which extends PDOException) never sets the errorInfo property — it is only populated by PHP's internal PDO C code, not when constructing PDOException subclasses in userland. This caused PHP warnings and a blank error message on installation failures. Use $err->getMessage() instead, which is always available, and remove the unused $err_code variable. Made-with: Cursor
The root-level phpunit/phpunit and yoast/phpunit-polyfills packages were only used by the legacy driver test suite, which was removed along with the root phpunit.xml.dist and tests/ directory. The new driver's tests live in packages/mysql-on-sqlite/ with their own composer.json and dependencies. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up items for consideration from reviewing #358