Fix string interpolation and platform where 'ip' command (from iproute2) is unavailable. by f1rmb · Pull Request #4734 · ZoneMinder/zoneminder

f1rmb · 2026-04-11T22:10:29Z

as from PHP 8.2, ${var} string interpolation is deprecated. the fix looks a bit hackish, but it should parse the correct syntax only.
on FreeBSD, the 'ip' command is not available. Also, the old code that parse the 'ifconfig' output looks a bit weird (probably really outdated). The new code works on Linux (6.19.11 here) and FreeBSD. Also, to get the default route interface, I've added a FreeBSD only code section. Later I will add a ZM_PATH_ROUTE in cmake / conf, for now the command is hardcoded, I will also add Linux support for default route detection when 'ip' is not available (unlikely). now get_network() works on FreeBSD too, interfaces array is no more empty.

…e2) is unavailable. - as from PHP 8.2, ${var} string interpolation is deprecated. the fix looks a bit hackish, but it should parse the correct syntax only. - on FreeBSD, the 'ip' command is not available. Also, the old code that parse the 'ifconfig' output looks a bit weird (probably really outdated). The new code works on Linux (6.19.11 here) and FreeBSD. Also, to get the default route interface, I've added a FreeBSD only code section. Later I will add a ZM_PATH_ROUTE in cmake / conf, for now the command is hardcoded, I will also add Linux support for default route detection when 'ip' is not available (unlikely). now get_network() works on FreeBSD too, interfaces array is no more empty.

IgorA100 · 2026-04-12T08:13:11Z

@f1rmb
Please format the code (use spaces instead of tabs).

…tion (space indent now).

f1rmb · 2026-04-12T09:20:18Z

@f1rmb Please format the code (use spaces instead of tabs).

Okay. Done. I had to reindent the whole function, as the code is (and still) a mix of tab/space indentation.
get_network() is now space indented.

IgorA100 · 2026-04-12T10:31:58Z

Yes, there is such a problem (spaces/tabs).
We should try to replace all tabs with spaces, including in existing code.

IgorA100 · 2026-04-12T10:39:00Z

get_network() is now space indented.

Your formatting uses 4 spaces, but 99% of the code uses 2 spaces.
It's probably not critical (Isaac has the final say), but it's ugly.

f1rmb · 2026-04-12T11:48:30Z

Well, tell me, I could reformat de whole code. But later, I don't have much time today.

…

--- 73 de Daniel, F1RMB

-------- Original Message --------

On Sunday, 04/12/26 at 12:39 IgorA100 ***@***.***> wrote: IgorA100 left a comment [(ZoneMinder/zoneminder#4734)](#4734 (comment)) > get_network() is now space indented. Your formatting uses 4 spaces, but 99% of the code uses 2 spaces. It's probably not critical (Isaac has the final say), but it's ugly. — Reply to this email directly, [view it on GitHub](#4734 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACP5DKB2VJGHF3P7C3V7YN34VNW5VAVCNFSM6AAAAACXVG6HJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMZRGMYTSMRWGI). You are receiving this because you were mentioned.Message ID: ***@***.***>

connortechnology · 2026-04-12T12:28:49Z

Yes we use 2space formatting. In general we use the google style guidelines, with a few exceptions.

That being said, I don't feel a need to be pedantic about this. As long as the code you change is formatted correctly and doesn't undo existing good formatting I don't care.

All that being said, I think the entire issue is stupid and I wish the world would move on. Your editor should display whatever formatting you prefer and the stored code should have almost no unnecessary white space at all. But I still use vim so I'm part of the problem, and as I age I find that consistent styling, helps my brain parse the code. So here we are, 2spaces please.

connortechnology · 2026-04-12T12:30:11Z

You may find it useful to setup git to auto-lint the code. We have an eslint ci setup to that checks js files, but you can set that up in git to do it before you even commit. Same for c++ code using cpplint etc. I find that very helpful.

f1rmb · 2026-04-12T13:13:28Z

Old school here too, I use Emacs ;-)

…

--- 73 de Daniel, F1RMB

-------- Original Message --------

On Sunday, 04/12/26 at 14:29 Isaac Connor ***@***.***> wrote: connortechnology left a comment [(ZoneMinder/zoneminder#4734)](#4734 (comment)) Yes we use 2space formatting. In general we use the google style guidelines, with a few exceptions. That being said, I don't feel a need to be pedantic about this. As long as the code you change is formatted correctly and doesn't undo existing good formatting I don't care. All that being said, I think the entire issue is stupid and I wish the world would move on. Your editor should display whatever formatting you prefer and the stored code should have almost no unnecessary white space at all. But I still use vim so I'm part of the problem, and as I age I find that consistent styling, helps my brain parse the code. So here we are, 2spaces please. — Reply to this email directly, [view it on GitHub](#4734 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACP5DKFDL2BIG5VIMOOM4C34VODZRAVCNFSM6AAAAACXVG6HJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMZRGUYDINZZGY). You are receiving this because you were mentioned.Message ID: ***@***.***>

connortechnology · 2026-04-14T12:52:00Z

        Please run the following command from a command line for more information:
        $shell_command"
-        );
+    );


All these whitespace changes should not be in this PR.

Copilot

Pull request overview

This PR updates ONVIF probe UI string building for PHP 8.2 compatibility and reworks network interface detection to function on platforms where ip (iproute2) is unavailable (e.g., FreeBSD).

Changes:

Replace deprecated PHP string interpolation in onvifprobe.php with concatenation.
Make ONVIF probe interface selection resilient when no default interface is returned.
Rework get_networks() to support an ifconfig-based fallback and add a FreeBSD-only default-route detection.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
web/skins/classic/views/onvifprobe.php	Avoids deprecated interpolation and avoids assuming `get_networks()` always returns a `default` key.
web/includes/functions.php	Updates `get_networks()` to enumerate interfaces via `ip` when present, otherwise via `ifconfig`, with a FreeBSD default-route lookup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-14T13:40:49Z

+            exec('ifconfig', $output, $status);
+
+            if ($status) {
+                $html_output = implode("\n", $output);
+                ZM\Error("Unable to list network interfaces, status is '$status'. Output was:$html_output");
+            } else {
+                array_walk($output, function($value, $key) use (&$interfaces) {
+                    $retval = preg_match("/^([A-Za-z0-9]*):\s+flags=([0-9]*)<([A-Z,]*)>.*/ims", $value, $matches);
+                    ZM\Debug(print_r($matches, true));
+                    if (($retval == 1) && (strlen($matches[3]) > 0) &&
+                        (strpos($matches[3], "LOOPBACK") == false) && (strpos($matches[3], "RUNNING") != false))
+                    {
+                        $interfaces[$matches[1]] = $matches[1];
+                    }
+                });
+
+                if (strcmp($osname, 'freebsd') == 0) {
+                    // Get default route iface
+                    exec("route get default | grep interface | awk '{print $2}'", $defaultIface, $status);
+
+                    if ($status) {
+                        $html_output = implode("\n", $output);
+                        ZM\Error("Unable to get default ip route, status is '$status'. Output was:$html_output");
+                    } else {
+                        if (isset($defaultIface) && isset($defaultIface[0])) {
+	                    $interfaces['default'] = $defaultIface[0];
+                        }


The ifconfig fallback runs exec(ZM_PATH_IFCONFIG, ...) and then immediately runs exec('ifconfig', ...), overwriting $output. If ZM_PATH_IFCONFIG succeeds but ifconfig isn’t in the web server PATH (common for /sbin tools), this will incorrectly fail. Use ZM_PATH_IFCONFIG for the actual call (and remove the redundant first/second exec).

Suggested change

exec('ifconfig', $output, $status);

if ($status) {

$html_output = implode("\n", $output);

ZM\Error("Unable to list network interfaces, status is '$status'. Output was:$html_output");

} else {

array_walk($output, function($value, $key) use (&$interfaces) {

$retval = preg_match("/^([A-Za-z0-9]*):\s+flags=([0-9]*)<([A-Z,]*)>.*/ims", $value, $matches);

ZM\Debug(print_r($matches, true));

if (($retval == 1) && (strlen($matches[3]) > 0) &&

(strpos($matches[3], "LOOPBACK") == false) && (strpos($matches[3], "RUNNING") != false))

{

$interfaces[$matches[1]] = $matches[1];

}

});

if (strcmp($osname, 'freebsd') == 0) {

// Get default route iface

exec("route get default | grep interface | awk '{print $2}'", $defaultIface, $status);

if ($status) {

$html_output = implode("\n", $output);

ZM\Error("Unable to get default ip route, status is '$status'. Output was:$html_output");

} else {

if (isset($defaultIface) && isset($defaultIface[0])) {

$interfaces['default'] = $defaultIface[0];

}

array_walk($output, function($value, $key) use (&$interfaces) {

$retval = preg_match("/^([A-Za-z0-9]*):\s+flags=([0-9]*)<([A-Z,]*)>.*/ims", $value, $matches);

ZM\Debug(print_r($matches, true));

if (($retval == 1) && (strlen($matches[3]) > 0) &&

(strpos($matches[3], "LOOPBACK") == false) && (strpos($matches[3], "RUNNING") != false))

{

$interfaces[$matches[1]] = $matches[1];

}

});

if (strcmp($osname, 'freebsd') == 0) {

// Get default route iface

exec("route get default | grep interface | awk '{print $2}'", $defaultIface, $status);

if ($status) {

$html_output = implode("\n", $output);

ZM\Error("Unable to get default ip route, status is '$status'. Output was:$html_output");

} else {

if (isset($defaultIface) && isset($defaultIface[0])) {

$interfaces['default'] = $defaultIface[0];

There are actually security issues around just running things and expecting PATH to find them. Sometimes the ZM admin is NOT the system admin. So system admin sets ZM_PATH_IFCONFIG and ZM admin just has to live with it.

Copilot · 2026-04-14T13:40:50Z

+                    $retval = preg_match("/^([A-Za-z0-9]*):\s+flags=([0-9]*)<([A-Z,]*)>.*/ims", $value, $matches);
+                    ZM\Debug(print_r($matches, true));
+                    if (($retval == 1) && (strlen($matches[3]) > 0) &&
+                        (strpos($matches[3], "LOOPBACK") == false) && (strpos($matches[3], "RUNNING") != false))


The strpos checks against the flags string use loose comparisons (== false / != false), which mis-handle matches at position 0 (e.g., strpos(...) returning 0). Use strict comparisons (=== false and !== false) so LOOPBACK/RUNNING detection is correct in all cases.

Suggested change

(strpos($matches[3], "LOOPBACK") == false) && (strpos($matches[3], "RUNNING") != false))

(strpos($matches[3], "LOOPBACK") === false) && (strpos($matches[3], "RUNNING") !== false))

Copilot · 2026-04-14T13:40:50Z

+                    exec("route get default | grep interface | awk '{print $2}'", $defaultIface, $status);
+
+                    if ($status) {
+                        $html_output = implode("\n", $output);
+                        ZM\Error("Unable to get default ip route, status is '$status'. Output was:$html_output");
+                    } else {
+                        if (isset($defaultIface) && isset($defaultIface[0])) {
+	                    $interfaces['default'] = $defaultIface[0];


In the FreeBSD default-route block, the error log builds $html_output from $output (the ifconfig output), not from $defaultIface (the route get default output), so failures will report the wrong command output. Also, this uses a shell pipeline (route | grep | awk) and unqualified command names, which is brittle if the web server PATH doesn’t include these tools; prefer executing the route command directly and parsing in PHP (or using configured full paths).

Suggested change

exec("route get default | grep interface | awk '{print $2}'", $defaultIface, $status);

if ($status) {

$html_output = implode("\n", $output);

ZM\Error("Unable to get default ip route, status is '$status'. Output was:$html_output");

} else {

if (isset($defaultIface) && isset($defaultIface[0])) {

$interfaces['default'] = $defaultIface[0];

$defaultIface = array();

$routeCommand = 'route';

if (is_executable('/sbin/route')) {

$routeCommand = '/sbin/route';

} else if (is_executable('/usr/sbin/route')) {

$routeCommand = '/usr/sbin/route';

}

exec($routeCommand.' get default', $defaultIface, $status);

if ($status) {

$html_output = implode("\n", $defaultIface);

ZM\Error("Unable to get default ip route, status is '$status'. Output was:$html_output");

} else {

foreach ($defaultIface as $routeLine) {

if (preg_match('/^\s*interface:\s*(\S+)/', $routeLine, $matches)) {

$interfaces['default'] = $matches[1];

break;

}

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ted_from_PHP_8_2_and_missing_ip_command_case' into fix_string_interpolation_deprecated_from_PHP_8_2_and_missing_ip_command_case

connortechnology reviewed Apr 11, 2026

View reviewed changes

Comment thread web/includes/functions.php Outdated

Revert unwanted change.

9681d00

Fix indentation stype (space vs tab) for the whole get_network() func…

f34f3ad

…tion (space indent now).

connortechnology reviewed Apr 12, 2026

View reviewed changes

Comment thread web/skins/classic/views/onvifprobe.php Outdated

connortechnology reviewed Apr 14, 2026

View reviewed changes

f1rmb force-pushed the fix_string_interpolation_deprecated_from_PHP_8_2_and_missing_ip_command_case branch from 60def0c to 8f3c9f6 Compare April 14, 2026 13:12

Remove string interpolation.

d627ca2

f1rmb force-pushed the fix_string_interpolation_deprecated_from_PHP_8_2_and_missing_ip_command_case branch from 8f3c9f6 to d627ca2 Compare April 14, 2026 13:13

connortechnology requested review from connortechnology and Copilot April 14, 2026 13:37

Copilot started reviewing on behalf of connortechnology April 14, 2026 13:38 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

f1rmb and others added 4 commits April 14, 2026 16:47

Add cmake/config ZM_PATH_ROUTE, and use it in get_network().

88d7c11

Apply suggestion from @Copilot

21cb8bf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Use strict operators with strpos().

7e28665

Merge remote-tracking branch 'origin/fix_string_interpolation_depreca…

1527ae6

…ted_from_PHP_8_2_and_missing_ip_command_case' into fix_string_interpolation_deprecated_from_PHP_8_2_and_missing_ip_command_case

	(strpos($matches[3], "LOOPBACK") == false) && (strpos($matches[3], "RUNNING") != false))
	(strpos($matches[3], "LOOPBACK") === false) && (strpos($matches[3], "RUNNING") !== false))

-                    exec("route get default | grep interface | awk '{print $2}'", $defaultIface, $status);
-                    if ($status) {
-                        $html_output = implode("\n", $output);
-                        ZM\Error("Unable to get default ip route, status is '$status'. Output was:$html_output");
-                    } else {
-                        if (isset($defaultIface) && isset($defaultIface[0])) {
-	                    $interfaces['default'] = $defaultIface[0];
+                    $defaultIface = array();
+                    $routeCommand = 'route';
+                    if (is_executable('/sbin/route')) {
+                        $routeCommand = '/sbin/route';
+                    } else if (is_executable('/usr/sbin/route')) {
+                        $routeCommand = '/usr/sbin/route';
+                    }
+                    exec($routeCommand.' get default', $defaultIface, $status);
+                    if ($status) {
+                        $html_output = implode("\n", $defaultIface);
+                        ZM\Error("Unable to get default ip route, status is '$status'. Output was:$html_output");
+                    } else {
+                        foreach ($defaultIface as $routeLine) {
+                            if (preg_match('/^\s*interface:\s*(\S+)/', $routeLine, $matches)) {
+                                $interfaces['default'] = $matches[1];
+                                break;
+                            }

Uh oh!

Conversation

f1rmb commented Apr 11, 2026

Uh oh!

Uh oh!

IgorA100 commented Apr 12, 2026

Uh oh!

f1rmb commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IgorA100 commented Apr 12, 2026

Uh oh!

IgorA100 commented Apr 12, 2026

Uh oh!

f1rmb commented Apr 12, 2026 via email

Uh oh!

connortechnology commented Apr 12, 2026

Uh oh!

connortechnology commented Apr 12, 2026

Uh oh!

Uh oh!

f1rmb commented Apr 12, 2026 via email

Uh oh!

connortechnology Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

connortechnology Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

f1rmb commented Apr 12, 2026 •

edited

Loading