Skip to content

feat(ui): add full control JSON editing and create-from-JSON#147

Open
lan17 wants to merge 1 commit intomainfrom
feature/control-json-editor-hint
Open

feat(ui): add full control JSON editing and create-from-JSON#147
lan17 wants to merge 1 commit intomainfrom
feature/control-json-editor-hint

Conversation

@lan17
Copy link
Contributor

@lan17 lan17 commented Mar 25, 2026

Summary

  • add Full JSON mode for editing the entire control definition from the control modal
  • add From JSON in the create-control flow so a control can be created directly from JSON without picking an evaluator first
  • reuse a shared JSON editor for both full control definitions and evaluator config JSON
  • add helper text clarifying that the control JSON editor expects the raw control definition, not data / name / id wrapper objects
  • add Playwright coverage for the JSON create/edit flows

Testing

  • make ui-typecheck
  • make ui-lint (passes; existing no-img-element warnings remain in ui/src/core/layouts/app-layout.tsx)

Screenshots

New control UI now has From JSON button`
image

When you click on it you get this
Screenshot 2026-03-24 at 9 11 12 PM

you can also edit full json in control now
Screenshot 2026-03-24 at 9 11 38 PM

@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@lan17 lan17 force-pushed the feature/control-json-editor-hint branch from fe8ddd4 to 5fa2b9f Compare March 25, 2026 02:36
@lan17 lan17 changed the title fix(ui): clarify control JSON editor input shape fix(ui): complete control JSON editor rollout Mar 25, 2026
@lan17 lan17 force-pushed the feature/control-json-editor-hint branch from 5fa2b9f to 7896863 Compare March 25, 2026 04:08
@lan17 lan17 changed the title fix(ui): complete control JSON editor rollout feat(ui): restore full control JSON editing and create-from-JSON Mar 25, 2026
@lan17 lan17 changed the title feat(ui): restore full control JSON editing and create-from-JSON feat(ui): add full control JSON editing and create-from-JSON Mar 25, 2026
@lan17 lan17 requested review from namrataghadi-galileo and siddhant-galileo and removed request for siddhant-galileo March 25, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant